From eeea3fb91b8dd177cf284a9cf7de0aec008c4e84 Mon Sep 17 00:00:00 2001 From: Giorgos Ntemiris Date: Mon, 19 Aug 2019 21:03:21 +0200 Subject: fs: allow passing true to emitClose option Allow passing true for emitClose option for fs streams. Fixes: https://github.com/nodejs/node/issues/29177 PR-URL: https://github.com/nodejs/node/pull/29212 Reviewed-By: Anna Henningsen Reviewed-By: James M Snell Reviewed-By: Colin Ihrig Reviewed-By: Trivikram Kamat --- lib/internal/fs/streams.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'lib/internal/fs') diff --git a/lib/internal/fs/streams.js b/lib/internal/fs/streams.js index 87d58a8be5..d51fbb1b58 100644 --- a/lib/internal/fs/streams.js +++ b/lib/internal/fs/streams.js @@ -61,7 +61,9 @@ function ReadStream(path, options) { options.highWaterMark = 64 * 1024; // For backwards compat do not emit close on destroy. - options.emitClose = false; + if (options.emitClose === undefined) { + options.emitClose = false; + } Readable.call(this, options); @@ -237,7 +239,9 @@ function WriteStream(path, options) { options = copyObject(getOptions(options, {})); // For backwards compat do not emit close on destroy. - options.emitClose = false; + if (options.emitClose === undefined) { + options.emitClose = false; + } Writable.call(this, options); -- cgit v1.2.3