diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-03-27 12:47:54 +0100 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-03-27 13:59:33 +0100 |
| commit | a8eac78f8dbe778a2aef69d0989416e47c6c403e (patch) | |
| tree | 0d50a806d306e316685cf5b60f4a3be98d7bf5b6 /lib/internal/console | |
| parent | ed5e69d7e6eaf5e887ff48aa3fe941d394c44846 (diff) | |
| download | android-node-v8-a8eac78f8dbe778a2aef69d0989416e47c6c403e.tar.gz android-node-v8-a8eac78f8dbe778a2aef69d0989416e47c6c403e.tar.bz2 android-node-v8-a8eac78f8dbe778a2aef69d0989416e47c6c403e.zip | |
Revert "console: use consolePropAttributes for k-bind properties in constructor"
This reverts commit ed5e69d7e6eaf5e887ff48aa3fe941d394c44846.
PR-URL: https://github.com/nodejs/node/pull/26943
Refs: https://github.com/nodejs/node/pull/26850#issuecomment-477089697
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'lib/internal/console')
| -rw-r--r-- | lib/internal/console/constructor.js | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js index fadb80e707..b00707d1fd 100644 --- a/lib/internal/console/constructor.js +++ b/lib/internal/console/constructor.js @@ -181,13 +181,15 @@ Console.prototype[kBindProperties] = function(ignoreErrors, colorMode) { ...consolePropAttributes, value: Boolean(ignoreErrors) }, - '_times': { ...consolePropAttributes, value: new Map() }, - // Corresponds to https://console.spec.whatwg.org/#count-map - [kCounts]: { ...consolePropAttributes, value: new Map() }, - [kColorMode]: { ...consolePropAttributes, value: colorMode }, - [kIsConsole]: { ...consolePropAttributes, value: true }, - [kGroupIndent]: { ...consolePropAttributes, value: '' } + '_times': { ...consolePropAttributes, value: new Map() } }); + + // TODO(joyeecheung): use consolePropAttributes for these + // Corresponds to https://console.spec.whatwg.org/#count-map + this[kCounts] = new Map(); + this[kColorMode] = colorMode; + this[kIsConsole] = true; + this[kGroupIndent] = ''; }; // Make a function that can serve as the callback passed to `stream.write()`. |