From a8eac78f8dbe778a2aef69d0989416e47c6c403e Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Wed, 27 Mar 2019 12:47:54 +0100 Subject: Revert "console: use consolePropAttributes for k-bind properties in constructor" This reverts commit ed5e69d7e6eaf5e887ff48aa3fe941d394c44846. PR-URL: https://github.com/nodejs/node/pull/26943 Refs: https://github.com/nodejs/node/pull/26850#issuecomment-477089697 Reviewed-By: Joyee Cheung Reviewed-By: Colin Ihrig Reviewed-By: Refael Ackermann --- lib/internal/console/constructor.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'lib/internal/console') diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js index fadb80e707..b00707d1fd 100644 --- a/lib/internal/console/constructor.js +++ b/lib/internal/console/constructor.js @@ -181,13 +181,15 @@ Console.prototype[kBindProperties] = function(ignoreErrors, colorMode) { ...consolePropAttributes, value: Boolean(ignoreErrors) }, - '_times': { ...consolePropAttributes, value: new Map() }, - // Corresponds to https://console.spec.whatwg.org/#count-map - [kCounts]: { ...consolePropAttributes, value: new Map() }, - [kColorMode]: { ...consolePropAttributes, value: colorMode }, - [kIsConsole]: { ...consolePropAttributes, value: true }, - [kGroupIndent]: { ...consolePropAttributes, value: '' } + '_times': { ...consolePropAttributes, value: new Map() } }); + + // TODO(joyeecheung): use consolePropAttributes for these + // Corresponds to https://console.spec.whatwg.org/#count-map + this[kCounts] = new Map(); + this[kColorMode] = colorMode; + this[kIsConsole] = true; + this[kGroupIndent] = ''; }; // Make a function that can serve as the callback passed to `stream.write()`. -- cgit v1.2.3