diff options
| author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-01-23 14:07:18 +0100 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-01-24 13:16:09 +0100 |
| commit | e65a6e81ef5e8c0afae4ffec852b662732114adb (patch) | |
| tree | f07404a4983170a8cce56a481300a96ac3536d59 /lib/assert.js | |
| parent | 8e6e1c9dcc83843aa17225b14ef91b92f337aebb (diff) | |
| download | android-node-v8-e65a6e81ef5e8c0afae4ffec852b662732114adb.tar.gz android-node-v8-e65a6e81ef5e8c0afae4ffec852b662732114adb.tar.bz2 android-node-v8-e65a6e81ef5e8c0afae4ffec852b662732114adb.zip | |
assert: stricter ifError
This makes `assert.ifError` stricter by only accepting `null` and
`undefined` from now on. Before any truthy value was accepted.
PR-URL: https://github.com/nodejs/node/pull/18247
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib/assert.js')
| -rw-r--r-- | lib/assert.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/assert.js b/lib/assert.js index 20f9d0e477..e25247dfed 100644 --- a/lib/assert.js +++ b/lib/assert.js @@ -453,7 +453,7 @@ assert.doesNotThrow = function doesNotThrow(block, error, message) { }; assert.ifError = function ifError(err) { - if (err) { + if (err !== null && err !== undefined) { let message = 'ifError got unwanted exception: '; if (typeof err === 'object' && typeof err.message === 'string') { if (err.message.length === 0 && err.constructor) { |