From e65a6e81ef5e8c0afae4ffec852b662732114adb Mon Sep 17 00:00:00 2001
From: Ruben Bridgewater <ruben@bridgewater.de>
Date: Tue, 23 Jan 2018 14:07:18 +0100
Subject: assert: stricter ifError

This makes `assert.ifError` stricter by only accepting `null` and
`undefined` from now on. Before any truthy value was accepted.

PR-URL: https://github.com/nodejs/node/pull/18247
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 lib/assert.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'lib/assert.js')

diff --git a/lib/assert.js b/lib/assert.js
index 20f9d0e477..e25247dfed 100644
--- a/lib/assert.js
+++ b/lib/assert.js
@@ -453,7 +453,7 @@ assert.doesNotThrow = function doesNotThrow(block, error, message) {
 };
 
 assert.ifError = function ifError(err) {
-  if (err) {
+  if (err !== null && err !== undefined) {
     let message = 'ifError got unwanted exception: ';
     if (typeof err === 'object' && typeof err.message === 'string') {
       if (err.message.length === 0 && err.constructor) {
-- 
cgit v1.2.3