diff options
| author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-01-15 23:37:09 +0100 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-01-16 19:57:36 +0100 |
| commit | d07c6f9739360954e8e6c6f16bf061a7f64bda9c (patch) | |
| tree | c842de376eb55a95a24a990d09bb7d010f13a1ff /lib/assert.js | |
| parent | f76ef504326f8a37cdb0d3dae705239d685abffc (diff) | |
| download | android-node-v8-d07c6f9739360954e8e6c6f16bf061a7f64bda9c.tar.gz android-node-v8-d07c6f9739360954e8e6c6f16bf061a7f64bda9c.tar.bz2 android-node-v8-d07c6f9739360954e8e6c6f16bf061a7f64bda9c.zip | |
assert: throw without args in ok
`assert.ok()` should always receive a value. Otherwise there
might be a bug or it was intended to use `assert.fail()`.
PR-URL: https://github.com/nodejs/node/pull/17581
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Diffstat (limited to 'lib/assert.js')
| -rw-r--r-- | lib/assert.js | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/assert.js b/lib/assert.js index a65be66ac7..db8ae35e07 100644 --- a/lib/assert.js +++ b/lib/assert.js @@ -133,6 +133,9 @@ function getBuffer(fd, assertLine) { function innerOk(args, fn) { var [value, message] = args; + if (args.length === 0) + throw new errors.TypeError('ERR_MISSING_ARGS', 'value'); + if (!value) { if (message == null) { // Use the call as error message if possible. |