From d07c6f9739360954e8e6c6f16bf061a7f64bda9c Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Mon, 15 Jan 2018 23:37:09 +0100 Subject: assert: throw without args in ok `assert.ok()` should always receive a value. Otherwise there might be a bug or it was intended to use `assert.fail()`. PR-URL: https://github.com/nodejs/node/pull/17581 Reviewed-By: Matteo Collina Reviewed-By: James M Snell Reviewed-By: Ron Korving --- lib/assert.js | 3 +++ 1 file changed, 3 insertions(+) (limited to 'lib/assert.js') diff --git a/lib/assert.js b/lib/assert.js index a65be66ac7..db8ae35e07 100644 --- a/lib/assert.js +++ b/lib/assert.js @@ -133,6 +133,9 @@ function getBuffer(fd, assertLine) { function innerOk(args, fn) { var [value, message] = args; + if (args.length === 0) + throw new errors.TypeError('ERR_MISSING_ARGS', 'value'); + if (!value) { if (message == null) { // Use the call as error message if possible. -- cgit v1.2.3