summaryrefslogtreecommitdiff
path: root/lib/_http_server.js
diff options
context:
space:
mode:
authorMatteo Collina <hello@matteocollina.com>2019-08-22 08:39:07 +0200
committerRich Trott <rtrott@gmail.com>2019-08-24 09:56:19 -0700
commita5d92887889b4cd1f80a47c67868905ce6c204f6 (patch)
tree4d451466295ba629d99ea314755bef6d462184d9 /lib/_http_server.js
parentd5c383706130638d9772c5fdc18545a90424bff3 (diff)
downloadandroid-node-v8-a5d92887889b4cd1f80a47c67868905ce6c204f6.tar.gz
android-node-v8-a5d92887889b4cd1f80a47c67868905ce6c204f6.tar.bz2
android-node-v8-a5d92887889b4cd1f80a47c67868905ce6c204f6.zip
Revert "http: reset parser.incoming when server response is finished"
This reverts commit 779a05d5d1bfe2eeb05386f6415d36f80ca0b3b5. PR-URL: https://github.com/nodejs/node/pull/29263 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'lib/_http_server.js')
-rw-r--r--lib/_http_server.js2
1 files changed, 0 insertions, 2 deletions
diff --git a/lib/_http_server.js b/lib/_http_server.js
index 2c48ab9191..862b7c970b 100644
--- a/lib/_http_server.js
+++ b/lib/_http_server.js
@@ -618,8 +618,6 @@ function resOnFinish(req, res, socket, state, server) {
assert(state.incoming.length === 0 || state.incoming[0] === req);
state.incoming.shift();
- // Reset the .incoming property so that the request object can be gc'ed.
- if (socket.parser) socket.parser.incoming = null;
// If the user never called req.read(), and didn't pipe() or
// .resume() or .on('data'), then we call req._dump() so that the