From a5d92887889b4cd1f80a47c67868905ce6c204f6 Mon Sep 17 00:00:00 2001 From: Matteo Collina Date: Thu, 22 Aug 2019 08:39:07 +0200 Subject: Revert "http: reset parser.incoming when server response is finished" This reverts commit 779a05d5d1bfe2eeb05386f6415d36f80ca0b3b5. PR-URL: https://github.com/nodejs/node/pull/29263 Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell Reviewed-By: Luigi Pinca --- lib/_http_server.js | 2 -- 1 file changed, 2 deletions(-) (limited to 'lib/_http_server.js') diff --git a/lib/_http_server.js b/lib/_http_server.js index 2c48ab9191..862b7c970b 100644 --- a/lib/_http_server.js +++ b/lib/_http_server.js @@ -618,8 +618,6 @@ function resOnFinish(req, res, socket, state, server) { assert(state.incoming.length === 0 || state.incoming[0] === req); state.incoming.shift(); - // Reset the .incoming property so that the request object can be gc'ed. - if (socket.parser) socket.parser.incoming = null; // If the user never called req.read(), and didn't pipe() or // .resume() or .on('data'), then we call req._dump() so that the -- cgit v1.2.3