diff options
author | Daniel Beckert <drbeckert@gmail.com> | 2018-12-13 15:35:48 -0200 |
---|---|---|
committer | Matheus Marchini <mat@mmarchini.me> | 2019-04-22 11:51:46 -0700 |
commit | ece507394a563bd7e3555a840a3d6980ffbb01ac (patch) | |
tree | 1d06fac01c1ca69e88107f718d12859f78a55295 /lib/_http_client.js | |
parent | 5aaf666b3b82a66485bea6a6b59fbfc838192e2f (diff) | |
download | android-node-v8-ece507394a563bd7e3555a840a3d6980ffbb01ac.tar.gz android-node-v8-ece507394a563bd7e3555a840a3d6980ffbb01ac.tar.bz2 android-node-v8-ece507394a563bd7e3555a840a3d6980ffbb01ac.zip |
src: do not reuse async resource in http parsers
Change resource being used, previously HTTParser was being reused.
We are now using IncomingMessage and ClientRequest objects. The goal
here is to make the async resource unique for each async operatio
Refs: https://github.com/nodejs/node/pull/24330
Refs: https://github.com/nodejs/diagnostics/issues/248
Refs: https://github.com/nodejs/node/pull/21313
Co-authored-by: Matheus Marchini <mat@mmarchini.me>
PR-URL: https://github.com/nodejs/node/pull/25094
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'lib/_http_client.js')
-rw-r--r-- | lib/_http_client.js | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/lib/_http_client.js b/lib/_http_client.js index e23c4909dd..895e0bd600 100644 --- a/lib/_http_client.js +++ b/lib/_http_client.js @@ -632,11 +632,10 @@ function emitFreeNT(socket) { } function tickOnSocket(req, socket) { - const isParserReused = parsers.hasItems(); const parser = parsers.alloc(); req.socket = socket; req.connection = socket; - parser.reinitialize(HTTPParser.RESPONSE, isParserReused); + parser.initialize(HTTPParser.RESPONSE, req); parser.socket = socket; parser.outgoing = req; req.parser = parser; |