From ece507394a563bd7e3555a840a3d6980ffbb01ac Mon Sep 17 00:00:00 2001 From: Daniel Beckert Date: Thu, 13 Dec 2018 15:35:48 -0200 Subject: src: do not reuse async resource in http parsers Change resource being used, previously HTTParser was being reused. We are now using IncomingMessage and ClientRequest objects. The goal here is to make the async resource unique for each async operatio Refs: https://github.com/nodejs/node/pull/24330 Refs: https://github.com/nodejs/diagnostics/issues/248 Refs: https://github.com/nodejs/node/pull/21313 Co-authored-by: Matheus Marchini PR-URL: https://github.com/nodejs/node/pull/25094 Reviewed-By: Matteo Collina Reviewed-By: Benedikt Meurer Reviewed-By: Anna Henningsen --- lib/_http_client.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'lib/_http_client.js') diff --git a/lib/_http_client.js b/lib/_http_client.js index e23c4909dd..895e0bd600 100644 --- a/lib/_http_client.js +++ b/lib/_http_client.js @@ -632,11 +632,10 @@ function emitFreeNT(socket) { } function tickOnSocket(req, socket) { - const isParserReused = parsers.hasItems(); const parser = parsers.alloc(); req.socket = socket; req.connection = socket; - parser.reinitialize(HTTPParser.RESPONSE, isParserReused); + parser.initialize(HTTPParser.RESPONSE, req); parser.socket = socket; parser.outgoing = req; req.parser = parser; -- cgit v1.2.3