diff options
| author | bcoe <bencoe@google.com> | 2019-12-01 12:55:54 -0800 |
|---|---|---|
| committer | Benjamin Coe <bencoe@google.com> | 2019-12-05 15:46:55 -0800 |
| commit | bfd9de63c9521a7d26ab27f87de386434bdf649b (patch) | |
| tree | 3c8c2ee89bc3a96f45cfbd0d2941c4caf6432ae7 /lib/.eslintrc.yaml | |
| parent | 651c43082698ba3bfa4f2417944719f771c09f04 (diff) | |
| download | android-node-v8-bfd9de63c9521a7d26ab27f87de386434bdf649b.tar.gz android-node-v8-bfd9de63c9521a7d26ab27f87de386434bdf649b.tar.bz2 android-node-v8-bfd9de63c9521a7d26ab27f87de386434bdf649b.zip | |
build: remove (almost) unused macros/constants
Macros, like CHECK, cause issues for tracking coverage because
they modify the source before it's placed in V8. Upon investigation
it seemed that we only used this functionality in two places:
internal/vm/module.js, and internal/async_hooks.js (in comments).
Given this, it seemed to make more sense to move CHECK to
JavaScript, and retire a mostly unused build step.
PR-URL: https://github.com/nodejs/node/pull/30755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib/.eslintrc.yaml')
| -rw-r--r-- | lib/.eslintrc.yaml | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml index 2823b7aa0d..ff9a0f595d 100644 --- a/lib/.eslintrc.yaml +++ b/lib/.eslintrc.yaml @@ -46,21 +46,6 @@ rules: node-core/non-ascii-character: error globals: Intl: false - # Assertions - CHECK: false - CHECK_EQ: false - CHECK_GE: false - CHECK_GT: false - CHECK_LE: false - CHECK_LT: false - CHECK_NE: false - DCHECK: false - DCHECK_EQ: false - DCHECK_GE: false - DCHECK_GT: false - DCHECK_LE: false - DCHECK_LT: false - DCHECK_NE: false # Parameters passed to internal modules global: false require: false |