build: remove (almost) unused macros/constants

Macros, like CHECK, cause issues for tracking coverage because
they modify the source before it's placed in V8. Upon investigation
it seemed that we only used this functionality in two places:
internal/vm/module.js, and internal/async_hooks.js (in comments).

Given this, it seemed to make more sense to move CHECK to
JavaScript, and retire a mostly unused build step.

PR-URL: https://github.com/nodejs/node/pull/30755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

2 files changed, 8 insertions, 17 deletions

diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml
index 2823b7aa0d..ff9a0f595d 100644
--- a/lib/.eslintrc.yaml
+++ b/lib/.eslintrc.yaml
@@ -46,21 +46,6 @@ rules:
   node-core/non-ascii-character: error
 globals:
   Intl: false
-  # Assertions
-  CHECK: false
-  CHECK_EQ: false
-  CHECK_GE: false
-  CHECK_GT: false
-  CHECK_LE: false
-  CHECK_LT: false
-  CHECK_NE: false
-  DCHECK: false
-  DCHECK_EQ: false
-  DCHECK_GE: false
-  DCHECK_GT: false
-  DCHECK_LE: false
-  DCHECK_LT: false
-  DCHECK_NE: false
   # Parameters passed to internal modules
   global: false
   require: false
diff --git a/lib/internal/vm/module.js b/lib/internal/vm/module.js
index 88a276e217..ee2fec2e43 100644
--- a/lib/internal/vm/module.js
+++ b/lib/internal/vm/module.js
@@ -1,5 +1,6 @@
 'use strict';
 
+const { fail } = require('internal/assert');
 const {
   ArrayIsArray,
   ObjectCreate,
@@ -58,6 +59,11 @@ const kContext = Symbol('kContext');
 const kPerContextModuleId = Symbol('kPerContextModuleId');
 const kLink = Symbol('kLink');
 
+function failIfDebug() {
+  if (process.features.debug === false) return;
+  fail('VM Modules');
+}
+
 class Module {
   constructor(options) {
     emitExperimentalWarning('VM Modules');
@@ -118,7 +124,7 @@ class Module {
                                    syntheticExportNames,
                                    syntheticEvaluationSteps);
     } else {
-      CHECK(false);
+      failIfDebug();
     }
 
     wrapToModuleMap.set(this[kWrap], this);
@@ -374,7 +380,7 @@ class SyntheticModule extends Module {
       identifier,
     });
 
-    this[kLink] = () => this[kWrap].link(() => { CHECK(false); });
+    this[kLink] = () => this[kWrap].link(() => { failIfDebug(); });
   }
 
   setExport(name, value) {