summaryrefslogtreecommitdiff
path: root/configure
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2018-06-08 13:18:27 -0700
committerRich Trott <rtrott@gmail.com>2018-06-08 20:16:42 -0700
commit8551d311bcbf6c5ebdd544c1409001eb5ba8e26b (patch)
tree29383734a9f90cc09dc3ec93c61ede4484eac7ba /configure
parent400df22c6bfefc3c3f54ebd7c5fd0d38f5137841 (diff)
downloadandroid-node-v8-8551d311bcbf6c5ebdd544c1409001eb5ba8e26b.tar.gz
android-node-v8-8551d311bcbf6c5ebdd544c1409001eb5ba8e26b.tar.bz2
android-node-v8-8551d311bcbf6c5ebdd544c1409001eb5ba8e26b.zip
build: use LC_ALL of C for maximum compatibility
LC_ALL=en_US breaks on some systems (notably the SmartOS 16 configuration in our CI). Use LC_ALL=C instead. PR-URL: https://github.com/nodejs/node/pull/21222 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'configure')
-rwxr-xr-xconfigure5
1 files changed, 1 insertions, 4 deletions
diff --git a/configure b/configure
index 5e365914d8..dcb8b03ebc 100755
--- a/configure
+++ b/configure
@@ -672,10 +672,7 @@ def get_xcode_version(cc):
def get_gas_version(cc):
try:
custom_env = os.environ.copy()
- # smartos (a.k.a. sunos5) does not have the en_US locale, and will give:
- # `setlocale: LC_ALL: cannot change locale (en_US): Invalid argument`
- if 'sunos' not in sys.platform:
- custom_env["LC_ALL"] = "en_US"
+ custom_env["LC_ALL"] = "C"
proc = subprocess.Popen(shlex.split(cc) + ['-Wa,-v', '-c', '-o',
'/dev/null', '-x',
'assembler', '/dev/null'],