summaryrefslogtreecommitdiff
path: root/configure
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2018-06-08 09:48:48 -0700
committerRich Trott <rtrott@gmail.com>2018-06-08 19:41:28 -0700
commit400df22c6bfefc3c3f54ebd7c5fd0d38f5137841 (patch)
tree6a38d25a9eef64b804f5194473b5eec8d7f3e9a2 /configure
parenta9e70d7d0b50ed615428e8344d510effb6713f02 (diff)
downloadandroid-node-v8-400df22c6bfefc3c3f54ebd7c5fd0d38f5137841.tar.gz
android-node-v8-400df22c6bfefc3c3f54ebd7c5fd0d38f5137841.tar.bz2
android-node-v8-400df22c6bfefc3c3f54ebd7c5fd0d38f5137841.zip
tools: update tooling to work with new macOS CLI …
Using High Sierra and `xcode-select --install` without installing full Xcode, our build tooling breaks due to faulty regular expressions. Update the `configure` script in our project root directory to handle multi-digit version numbers. `tools/gyp` and `deps/npm/node_modules/node-gyp` still need to be updated for a complete fix. PR-URL: https://github.com/nodejs/node/pull/21173 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'configure')
-rwxr-xr-xconfigure2
1 files changed, 1 insertions, 1 deletions
diff --git a/configure b/configure
index db9c45a868..5e365914d8 100755
--- a/configure
+++ b/configure
@@ -667,7 +667,7 @@ def get_llvm_version(cc):
def get_xcode_version(cc):
return get_version_helper(
- cc, r"(^Apple LLVM version) ([5-9]\.[0-9]+)")
+ cc, r"(^Apple LLVM version) ([0-9]+\.[0-9]+)")
def get_gas_version(cc):
try: