http2: switch to new runtime-controlled debugging system

Remove `--debug-http2` as a compile-time feature and
make all debug statements available using `NODE_DEBUG_NATIVE=http2`
at runtime.

This probably makes the debugging-enabled case a bit slower due to
additional string concatenations, but switching to a runtime-checking
system makes debugging more flexible and can be applied more easily
to other parts of the source code as well.

PR-URL: https://github.com/nodejs/node/pull/20987
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1 files changed, 0 insertions, 10 deletions

diff --git a/configure b/configure
index 17e13a48d4..c4dda999fd 100755
--- a/configure
+++ b/configure
@@ -443,11 +443,6 @@ parser.add_option('--debug-lib',
     dest='node_debug_lib',
     help='build lib with DCHECK macros')
 
-http2_optgroup.add_option('--debug-http2',
-    action='store_true',
-    dest='debug_http2',
-    help='build with http2 debug statements on (default is false)')
-
 http2_optgroup.add_option('--debug-nghttp2',
     action='store_true',
     dest='debug_nghttp2',
@@ -970,11 +965,6 @@ def configure_node(o):
 
   o['variables']['node_debug_lib'] = b(options.node_debug_lib)
 
-  if options.debug_http2:
-    o['variables']['debug_http2'] = 1
-  else:
-    o['variables']['debug_http2'] = 'false'
-
   if options.debug_nghttp2:
     o['variables']['debug_nghttp2'] = 1
   else: