From 15c7a49bfca1db23f4f7a3a79aea04a0075fbd62 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Sun, 27 May 2018 16:41:35 +0200 Subject: http2: switch to new runtime-controlled debugging system Remove `--debug-http2` as a compile-time feature and make all debug statements available using `NODE_DEBUG_NATIVE=http2` at runtime. This probably makes the debugging-enabled case a bit slower due to additional string concatenations, but switching to a runtime-checking system makes debugging more flexible and can be applied more easily to other parts of the source code as well. PR-URL: https://github.com/nodejs/node/pull/20987 Reviewed-By: Daniel Bevenius Reviewed-By: Joyee Cheung Reviewed-By: Minwoo Jung Reviewed-By: James M Snell --- configure | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'configure') diff --git a/configure b/configure index 17e13a48d4..c4dda999fd 100755 --- a/configure +++ b/configure @@ -443,11 +443,6 @@ parser.add_option('--debug-lib', dest='node_debug_lib', help='build lib with DCHECK macros') -http2_optgroup.add_option('--debug-http2', - action='store_true', - dest='debug_http2', - help='build with http2 debug statements on (default is false)') - http2_optgroup.add_option('--debug-nghttp2', action='store_true', dest='debug_nghttp2', @@ -970,11 +965,6 @@ def configure_node(o): o['variables']['node_debug_lib'] = b(options.node_debug_lib) - if options.debug_http2: - o['variables']['debug_http2'] = 1 - else: - o['variables']['debug_http2'] = 'false' - if options.debug_nghttp2: o['variables']['debug_nghttp2'] = 1 else: -- cgit v1.2.3