diff options
| author | Gireesh Punathil <gpunathi@in.ibm.com> | 2018-09-05 10:06:59 -0400 |
|---|---|---|
| committer | Gireesh Punathil <gpunathi@in.ibm.com> | 2019-01-18 10:34:04 +0530 |
| commit | 4f6797378eb6dd290dd5d8dc6417fea22d42ebad (patch) | |
| tree | 88967037a1ba9aec47faea701efecf4f44007587 /configure.py | |
| parent | 01cd21973b26a2cbacbe143c5983cb4adf8e7681 (diff) | |
| download | android-node-v8-4f6797378eb6dd290dd5d8dc6417fea22d42ebad.tar.gz android-node-v8-4f6797378eb6dd290dd5d8dc6417fea22d42ebad.tar.bz2 android-node-v8-4f6797378eb6dd290dd5d8dc6417fea22d42ebad.zip | |
src: merge into core
Make node-report part of core runtime because:
1. When enabled, node-report significantly helps root cause various
types of problems, including support issues sent to the various repos
of the Node.js organization.
2. The requirement of explicitly adding the dependency to node-report
in user applications often represents a blocker to adoption.
Major deviation from the module version of the node-report is that the
report is generated in JSON format, as opposed to human readable text.
No new functionalities have been added, changes that are required for
melding it as a built-in capability has been affected on the module
version of node-report (https://github.com/nodejs/node-report)
Co-authored-by: Bidisha Pyne <bidipyne@in.ibm.com>
Co-authored-by: Howard Hellyer <hhellyer@uk.ibm.com>
Co-authored-by: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Co-authored-by: Julian Alimin <dmastag@yahoo.com>
Co-authored-by: Lakshmi Swetha Gopireddy <lakshmigopireddy@in.ibm.com>
Co-authored-by: Manusaporn Treerungroj <m.treerungroj@gmail.com>
Co-authored-by: Michael Dawson <michael_dawson@ca.ibm.com>
Co-authored-by: Richard Chamberlain <richard_chamberlain@uk.ibm.com>
Co-authored-by: Richard Lau <riclau@uk.ibm.com>
Co-authored-by: Sam Roberts <vieuxtech@gmail.com>
Co-authored-by: Vipin Menon <vipinmv1@in.ibm.com>
PR-URL: https://github.com/nodejs/node/pull/22712
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Diffstat (limited to 'configure.py')
| -rwxr-xr-x | configure.py | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/configure.py b/configure.py index 8cb4c58c21..aa104b298d 100755 --- a/configure.py +++ b/configure.py @@ -493,6 +493,11 @@ parser.add_option('--without-npm', dest='without_npm', help='do not install the bundled npm (package manager)') +parser.add_option('--without-report', + action='store_true', + dest='without_report', + help='build without report') + # Dummy option for backwards compatibility parser.add_option('--with-snapshot', action='store_true', @@ -938,6 +943,7 @@ def configure_node(o): o['variables']['OS'] = 'android' o['variables']['node_prefix'] = options.prefix o['variables']['node_install_npm'] = b(not options.without_npm) + o['variables']['node_report'] = b(not options.without_report) o['default_configuration'] = 'Debug' if options.debug else 'Release' host_arch = host_arch_win() if os.name == 'nt' else host_arch_cc() |