From 4f6797378eb6dd290dd5d8dc6417fea22d42ebad Mon Sep 17 00:00:00 2001 From: Gireesh Punathil Date: Wed, 5 Sep 2018 10:06:59 -0400 Subject: src: merge into core Make node-report part of core runtime because: 1. When enabled, node-report significantly helps root cause various types of problems, including support issues sent to the various repos of the Node.js organization. 2. The requirement of explicitly adding the dependency to node-report in user applications often represents a blocker to adoption. Major deviation from the module version of the node-report is that the report is generated in JSON format, as opposed to human readable text. No new functionalities have been added, changes that are required for melding it as a built-in capability has been affected on the module version of node-report (https://github.com/nodejs/node-report) Co-authored-by: Bidisha Pyne Co-authored-by: Howard Hellyer Co-authored-by: Jeremiah Senkpiel Co-authored-by: Julian Alimin Co-authored-by: Lakshmi Swetha Gopireddy Co-authored-by: Manusaporn Treerungroj Co-authored-by: Michael Dawson Co-authored-by: Richard Chamberlain Co-authored-by: Richard Lau Co-authored-by: Sam Roberts Co-authored-by: Vipin Menon PR-URL: https://github.com/nodejs/node/pull/22712 Reviewed-By: Anna Henningsen Reviewed-By: James M Snell Reviewed-By: Michael Dawson Reviewed-By: Vse Mozhet Byt --- configure.py | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'configure.py') diff --git a/configure.py b/configure.py index 8cb4c58c21..aa104b298d 100755 --- a/configure.py +++ b/configure.py @@ -493,6 +493,11 @@ parser.add_option('--without-npm', dest='without_npm', help='do not install the bundled npm (package manager)') +parser.add_option('--without-report', + action='store_true', + dest='without_report', + help='build without report') + # Dummy option for backwards compatibility parser.add_option('--with-snapshot', action='store_true', @@ -938,6 +943,7 @@ def configure_node(o): o['variables']['OS'] = 'android' o['variables']['node_prefix'] = options.prefix o['variables']['node_install_npm'] = b(not options.without_npm) + o['variables']['node_report'] = b(not options.without_report) o['default_configuration'] = 'Debug' if options.debug else 'Release' host_arch = host_arch_win() if os.name == 'nt' else host_arch_cc() -- cgit v1.2.3