diff options
| author | Rod Vagg <rod@vagg.org> | 2019-03-01 11:22:06 +1100 |
|---|---|---|
| committer | Rod Vagg <rod@vagg.org> | 2019-03-12 13:10:52 +1100 |
| commit | 2fa8dc47f3f3a548dd78ccb41bf1d082c1628dfb (patch) | |
| tree | 6723d381e1ee34c87fc7c51f2ceb6c534862142f /configure.py | |
| parent | e1cd8ac00760eaf62ee9d51b872a6602d3e932ef (diff) | |
| download | android-node-v8-2fa8dc47f3f3a548dd78ccb41bf1d082c1628dfb.tar.gz android-node-v8-2fa8dc47f3f3a548dd78ccb41bf1d082c1628dfb.tar.bz2 android-node-v8-2fa8dc47f3f3a548dd78ccb41bf1d082c1628dfb.zip | |
build: enable v8's siphash for hash seed creation
Triggers the V8_USE_SIPHASH to switch from the internal custom V8
hash seed generation function to an implementation of SipHash. Final
step needed to clear up HashWick.
PR-URL: https://github.com/nodejs/node/pull/26367
Refs: https://github.com/nodejs/node/issues/23259
Refs: https://darksi.de/12.hashwick-v8-vulnerability/
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Diffstat (limited to 'configure.py')
| -rwxr-xr-x | configure.py | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/configure.py b/configure.py index 83703964e5..1f12998b64 100755 --- a/configure.py +++ b/configure.py @@ -477,6 +477,11 @@ parser.add_option('--without-snapshot', dest='without_snapshot', help=optparse.SUPPRESS_HELP) +parser.add_option('--without-siphash', + action='store_true', + dest='without_siphash', + help=optparse.SUPPRESS_HELP) + parser.add_option('--code-cache-path', action='store', dest='code_cache_path', @@ -1122,6 +1127,7 @@ def configure_v8(o): o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables. o['variables']['v8_promise_internal_field_count'] = 1 # Add internal field to promises for async hooks. o['variables']['v8_use_snapshot'] = 'false' if options.without_snapshot else 'true' + o['variables']['v8_use_siphash'] = 'false' if options.without_siphash else 'true' o['variables']['v8_trace_maps'] = 1 if options.trace_maps else 0 o['variables']['node_use_v8_platform'] = b(not options.without_v8_platform) o['variables']['node_use_bundled_v8'] = b(not options.without_bundled_v8) |