From 2fa8dc47f3f3a548dd78ccb41bf1d082c1628dfb Mon Sep 17 00:00:00 2001 From: Rod Vagg Date: Fri, 1 Mar 2019 11:22:06 +1100 Subject: build: enable v8's siphash for hash seed creation Triggers the V8_USE_SIPHASH to switch from the internal custom V8 hash seed generation function to an implementation of SipHash. Final step needed to clear up HashWick. PR-URL: https://github.com/nodejs/node/pull/26367 Refs: https://github.com/nodejs/node/issues/23259 Refs: https://darksi.de/12.hashwick-v8-vulnerability/ Reviewed-By: Gus Caplan Reviewed-By: Richard Lau Reviewed-By: Refael Ackermann Reviewed-By: Ben Noordhuis Reviewed-By: Ruben Bridgewater Reviewed-By: Fedor Indutny Reviewed-By: James M Snell Reviewed-By: Yang Guo Reviewed-By: Ujjwal Sharma --- configure.py | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'configure.py') diff --git a/configure.py b/configure.py index 83703964e5..1f12998b64 100755 --- a/configure.py +++ b/configure.py @@ -477,6 +477,11 @@ parser.add_option('--without-snapshot', dest='without_snapshot', help=optparse.SUPPRESS_HELP) +parser.add_option('--without-siphash', + action='store_true', + dest='without_siphash', + help=optparse.SUPPRESS_HELP) + parser.add_option('--code-cache-path', action='store', dest='code_cache_path', @@ -1122,6 +1127,7 @@ def configure_v8(o): o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables. o['variables']['v8_promise_internal_field_count'] = 1 # Add internal field to promises for async hooks. o['variables']['v8_use_snapshot'] = 'false' if options.without_snapshot else 'true' + o['variables']['v8_use_siphash'] = 'false' if options.without_siphash else 'true' o['variables']['v8_trace_maps'] = 1 if options.trace_maps else 0 o['variables']['node_use_v8_platform'] = b(not options.without_v8_platform) o['variables']['node_use_bundled_v8'] = b(not options.without_bundled_v8) -- cgit v1.2.3