diff options
| author | Anna Henningsen <anna@addaleax.net> | 2017-10-12 09:12:12 +0200 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2017-10-15 12:30:00 +0200 |
| commit | cc443cb44706d5751378d6512ab619eed9976150 (patch) | |
| tree | ef97f57c4c4fe47193548bcd3e884187cbe93ae2 /common.gypi | |
| parent | 411695e1d26565c7498992be19731bbea6b6aa58 (diff) | |
| download | android-node-v8-cc443cb44706d5751378d6512ab619eed9976150.tar.gz android-node-v8-cc443cb44706d5751378d6512ab619eed9976150.tar.bz2 android-node-v8-cc443cb44706d5751378d6512ab619eed9976150.zip | |
build: set disable_glibcxx_debug flag
This breaks a few tests when Node is built in debug mode, because
V8 is built with `-D_GLIBCXX_DEBUG=1` and Node is built without,
which makes e.g. `std::vector` ABI-incompatible between the two.
PR-URL: https://github.com/nodejs/node/pull/16159
Reviewed-By: James Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/common.gypi b/common.gypi index 6677274f3a..98268068f9 100644 --- a/common.gypi +++ b/common.gypi @@ -31,6 +31,10 @@ # Don't bake anything extra into the snapshot. 'v8_use_external_startup_data%': 0, + # Some STL containers (e.g. std::vector) do not preserve ABI compatibility + # between debug and non-debug mode. + 'disable_glibcxx_debug': 1, + # Don't use ICU data file (icudtl.dat) from V8, we use our own. 'icu_use_data_file_flag%': 0, |