From cc443cb44706d5751378d6512ab619eed9976150 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Thu, 12 Oct 2017 09:12:12 +0200 Subject: build: set disable_glibcxx_debug flag This breaks a few tests when Node is built in debug mode, because V8 is built with `-D_GLIBCXX_DEBUG=1` and Node is built without, which makes e.g. `std::vector` ABI-incompatible between the two. PR-URL: https://github.com/nodejs/node/pull/16159 Reviewed-By: James Snell Reviewed-By: Franziska Hinkelmann Reviewed-By: Ben Noordhuis --- common.gypi | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'common.gypi') diff --git a/common.gypi b/common.gypi index 6677274f3a..98268068f9 100644 --- a/common.gypi +++ b/common.gypi @@ -31,6 +31,10 @@ # Don't bake anything extra into the snapshot. 'v8_use_external_startup_data%': 0, + # Some STL containers (e.g. std::vector) do not preserve ABI compatibility + # between debug and non-debug mode. + 'disable_glibcxx_debug': 1, + # Don't use ICU data file (icudtl.dat) from V8, we use our own. 'icu_use_data_file_flag%': 0, -- cgit v1.2.3