diff options
| author | Michaël Zasso <targos@protonmail.com> | 2019-06-17 13:12:48 +0200 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2019-08-01 12:56:16 +0200 |
| commit | 4f3cfb2f7f51af4594893599c9719208df83b468 (patch) | |
| tree | 06ba77242d78721e8a9fc323c230adf619d3c587 /common.gypi | |
| parent | 526c4f34cadbc7e5a1837d19108b200bd278364f (diff) | |
| download | android-node-v8-4f3cfb2f7f51af4594893599c9719208df83b468.tar.gz android-node-v8-4f3cfb2f7f51af4594893599c9719208df83b468.tar.bz2 android-node-v8-4f3cfb2f7f51af4594893599c9719208df83b468.zip | |
deps: V8: cherry-pick 3b8c624
Original commit message:
GCC: explicitely instantiate JSObject::ApplyAttributesToDictionary for NumberDictionary
elements.cc invokes ApplyAttributesToDictionary using NumberDictionary as its template
parameter. But the declaration of the template method is in js-object.cc, so nobody
can actually compile the version for number dictionary. This is fixed requesting
explicit instantiation for NumberDictionary.
This was breaking GCC build.
Bug: chromium:819294
Change-Id: I685ddc5b97e129d1a534dbdb04025c0932bc5ecd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649565
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#62097}
Refs: https://github.com/v8/v8/commit/3b8c624bda58d05aea80dd9626cd550537d6ac3f
PR-URL: https://github.com/nodejs/node/pull/28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi index 4119517dbb..5ea3e36506 100644 --- a/common.gypi +++ b/common.gypi @@ -39,7 +39,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.10', + 'v8_embedder_string': '-node.11', ##### V8 defaults for Node.js ##### |