From 4f3cfb2f7f51af4594893599c9719208df83b468 Mon Sep 17 00:00:00 2001 From: Michaël Zasso Date: Mon, 17 Jun 2019 13:12:48 +0200 Subject: deps: V8: cherry-pick 3b8c624 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Original commit message: GCC: explicitely instantiate JSObject::ApplyAttributesToDictionary for NumberDictionary elements.cc invokes ApplyAttributesToDictionary using NumberDictionary as its template parameter. But the declaration of the template method is in js-object.cc, so nobody can actually compile the version for number dictionary. This is fixed requesting explicit instantiation for NumberDictionary. This was breaking GCC build. Bug: chromium:819294 Change-Id: I685ddc5b97e129d1a534dbdb04025c0932bc5ecd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649565 Reviewed-by: Toon Verwaest Commit-Queue: José Dapena Paz Cr-Commit-Position: refs/heads/master@{#62097} Refs: https://github.com/v8/v8/commit/3b8c624bda58d05aea80dd9626cd550537d6ac3f PR-URL: https://github.com/nodejs/node/pull/28016 Reviewed-By: Colin Ihrig Reviewed-By: Refael Ackermann (רפאל פלחי) Reviewed-By: Rich Trott Reviewed-By: Michael Dawson Reviewed-By: Jiawen Geng --- common.gypi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'common.gypi') diff --git a/common.gypi b/common.gypi index 4119517dbb..5ea3e36506 100644 --- a/common.gypi +++ b/common.gypi @@ -39,7 +39,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.10', + 'v8_embedder_string': '-node.11', ##### V8 defaults for Node.js ##### -- cgit v1.2.3