diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-03-19 12:02:18 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-03-21 20:14:25 -0700 |
| commit | f3e078fdce38cd8526e4f7f3aa657e030f141efc (patch) | |
| tree | cee8a107c3f85cfc10f3fc4087512a1009c39532 /COLLABORATOR_GUIDE.md | |
| parent | be470943fb8b6d1a9589b7aa18ddea207cb56304 (diff) | |
| download | android-node-v8-f3e078fdce38cd8526e4f7f3aa657e030f141efc.tar.gz android-node-v8-f3e078fdce38cd8526e4f7f3aa657e030f141efc.tar.bz2 android-node-v8-f3e078fdce38cd8526e4f7f3aa657e030f141efc.zip | |
doc: reduce CI options in COLLABORATOR_GUIDE.md
PR-URL: https://github.com/nodejs/node/pull/19458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 941694ced3..6ffa73c2ff 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -192,9 +192,9 @@ All bugfixes require a test case which demonstrates the defect. The test should *fail* before the change, and *pass* after the change. All pull requests that modify executable code should also include a test case -and be subjected to continuous integration tests on the +and must be subjected to continuous integration tests on the [project CI server](https://ci.nodejs.org/). The pull request should have a CI -status indicator if possible. +status indicator. #### Useful CI Jobs @@ -203,13 +203,9 @@ is the standard CI run we do to check Pull Requests. It triggers `node-test-commit`, which runs the `build-ci` and `test-ci` targets on all supported platforms. -* [`node-test-linter`](https://ci.nodejs.org/job/node-test-linter/) -only runs the linter targets, which is useful for changes that only affect -comments or documentation. - * [`node-test-pull-request-lite`](https://ci.nodejs.org/job/node-test-pull-request-lite/) -only runs the linter job, as well as the tests on LinuxONE. Should only be used -for trivial changes that do not require being tested on all platforms. +only runs the linter job, as well as the tests on LinuxONE, which is very fast. +This is useful for changes that only affect comments or documentation. * [`citgm-smoker`](https://ci.nodejs.org/job/citgm-smoker/) uses [`CitGM`](https://github.com/nodejs/citgm) to allow you to run |