diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-06-14 20:43:49 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-06-17 22:08:59 -0700 |
| commit | a13eba7e9fa86b1a4bf8374e9e3d1d8f646a01d4 (patch) | |
| tree | 570b7a3bf70a29ef8fc35fb9132632e548bcb907 /.eslintrc.js | |
| parent | b6b019f37bcc72946f21de4db81d58ba53a0de1f (diff) | |
| download | android-node-v8-a13eba7e9fa86b1a4bf8374e9e3d1d8f646a01d4.tar.gz android-node-v8-a13eba7e9fa86b1a4bf8374e9e3d1d8f646a01d4.tar.bz2 android-node-v8-a13eba7e9fa86b1a4bf8374e9e3d1d8f646a01d4.zip | |
tools: do not disable `quotes` rule in .eslintrc.js
Re-enable `quotes` rule in .eslintrc.js and fix code to abide by the
rule. As a bonus, this makes the code (IMO, anyway) more readable. (It
certainly isn't *less* readable, at least not IMO.)
PR-URL: https://github.com/nodejs/node/pull/21338
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to '.eslintrc.js')
| -rw-r--r-- | .eslintrc.js | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/.eslintrc.js b/.eslintrc.js index 9a4ffea210..dc83c0e8c1 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -147,32 +147,32 @@ module.exports = { message: '__defineSetter__ is deprecated.', } ], - /* eslint-disable max-len, quotes */ + /* eslint-disable max-len */ // If this list is modified, please copy the change to lib/.eslintrc.yaml 'no-restricted-syntax': [ 'error', { selector: "CallExpression[callee.object.name='assert'][callee.property.name='doesNotThrow']", - message: "Please replace `assert.doesNotThrow()` and add a comment next to the code instead." + message: 'Please replace `assert.doesNotThrow()` and add a comment next to the code instead.' }, { - selector: `CallExpression[callee.object.name='assert'][callee.property.name='rejects'][arguments.length<2]`, + selector: "CallExpression[callee.object.name='assert'][callee.property.name='rejects'][arguments.length<2]", message: 'assert.rejects() must be invoked with at least two arguments.', }, { - selector: `CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])`, + selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])", message: 'Use an object as second argument of assert.throws()', }, { - selector: `CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.length<2]`, + selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.length<2]", message: 'assert.throws() must be invoked with at least two arguments.', }, { - selector: `CallExpression[callee.name='setTimeout'][arguments.length<2]`, + selector: "CallExpression[callee.name='setTimeout'][arguments.length<2]", message: 'setTimeout() must be invoked with at least two arguments.', }, { - selector: `CallExpression[callee.name='setInterval'][arguments.length<2]`, + selector: "CallExpression[callee.name='setInterval'][arguments.length<2]", message: 'setInterval() must be invoked with at least 2 arguments.', }, { |