From a13eba7e9fa86b1a4bf8374e9e3d1d8f646a01d4 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 14 Jun 2018 20:43:49 -0700 Subject: tools: do not disable `quotes` rule in .eslintrc.js MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Re-enable `quotes` rule in .eslintrc.js and fix code to abide by the rule. As a bonus, this makes the code (IMO, anyway) more readable. (It certainly isn't *less* readable, at least not IMO.) PR-URL: https://github.com/nodejs/node/pull/21338 Reviewed-By: Gus Caplan Reviewed-By: Luigi Pinca Reviewed-By: Michaël Zasso Reviewed-By: Weijia Wang Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Trivikram Kamat --- .eslintrc.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to '.eslintrc.js') diff --git a/.eslintrc.js b/.eslintrc.js index 9a4ffea210..dc83c0e8c1 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -147,32 +147,32 @@ module.exports = { message: '__defineSetter__ is deprecated.', } ], - /* eslint-disable max-len, quotes */ + /* eslint-disable max-len */ // If this list is modified, please copy the change to lib/.eslintrc.yaml 'no-restricted-syntax': [ 'error', { selector: "CallExpression[callee.object.name='assert'][callee.property.name='doesNotThrow']", - message: "Please replace `assert.doesNotThrow()` and add a comment next to the code instead." + message: 'Please replace `assert.doesNotThrow()` and add a comment next to the code instead.' }, { - selector: `CallExpression[callee.object.name='assert'][callee.property.name='rejects'][arguments.length<2]`, + selector: "CallExpression[callee.object.name='assert'][callee.property.name='rejects'][arguments.length<2]", message: 'assert.rejects() must be invoked with at least two arguments.', }, { - selector: `CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])`, + selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])", message: 'Use an object as second argument of assert.throws()', }, { - selector: `CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.length<2]`, + selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.length<2]", message: 'assert.throws() must be invoked with at least two arguments.', }, { - selector: `CallExpression[callee.name='setTimeout'][arguments.length<2]`, + selector: "CallExpression[callee.name='setTimeout'][arguments.length<2]", message: 'setTimeout() must be invoked with at least two arguments.', }, { - selector: `CallExpression[callee.name='setInterval'][arguments.length<2]`, + selector: "CallExpression[callee.name='setInterval'][arguments.length<2]", message: 'setInterval() must be invoked with at least 2 arguments.', }, { -- cgit v1.2.3