summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-09-27fix build scriptsHEADmasterJonathan Buchanan
2022-07-18Build with debug symbols and strip them from release binariesJonathan Buchanan
2022-07-15build different architectures in different directoriesJonathan Buchanan
2022-06-13fix job number in MakefileJonathan Buchanan
2021-07-16reduce build size and build timeJonathan Buchanan
2021-07-07cache builds for each platform to avoid full rebuildsJonathan Buchanan
2021-06-22add dynamic module loaderJonathan Buchanan
2021-01-12edit build process so node runs properly on iosJonathan Buchanan
2020-12-30add build rules for ios arm64Jonathan Buchanan
2020-12-23doc: remove replication of GitHub templateRich Trott
The pull-request template was replicated in the pull-requests.md which is a maintenance annoyance when changing the template. Replace the replication with a link to the raw template. PR-URL: https://github.com/nodejs/node/pull/36590 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
2020-12-23doc: remove "Related Issues" from pull request templateRich Trott
We don't require an issue for a pull request, so this section usually ends up displaying confusing default content. PR-URL: https://github.com/nodejs/node/pull/36590 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
2020-12-22doc: expand openssl instructionsMichael Dawson
Refs: https://github.com/nodejs/node/pull/36541 Expand the instructions to cover what is needed when updates are required across all active release lines PR-URL: https://github.com/nodejs/node/pull/36554 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
2020-12-22v8: refactor to use more primordialsAntoine du Hamel
PR-URL: https://github.com/nodejs/node/pull/36527 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
2020-12-222020-12-22, Version 15.5.0 (Current)Michaël Zasso
Notable changes: child_process: * (SEMVER-MINOR) add signal support to spawn (Benjamin Gruenbaum) https://github.com/nodejs/node/pull/36432 doc: * add PoojaDurgad to collaborators (Pooja D P) https://github.com/nodejs/node/pull/36511 lib: * (SEMVER-MINOR) support BigInt in querystring.stringify (raisinten) https://github.com/nodejs/node/pull/36499 src: * (SEMVER-MINOR) add way to get IsolateData and allocator from Environment (Anna Henningsen) https://github.com/nodejs/node/pull/36441 * (SEMVER-MINOR) allow preventing SetPrepareStackTraceCallback (Shelley Vohr) https://github.com/nodejs/node/pull/36447 stream: * (SEMVER-MINOR) support abortsignal in constructor (Benjamin Gruenbaum) https://github.com/nodejs/node/pull/36431 PR-URL: https://github.com/nodejs/node/pull/36597
2020-12-22child_process: clean event listener correctlyBenjamin Gruenbaum
I was working on AbortSignal for spawn and noticed there is a leak in the current code for AbortSignal support in child_process since it removes the wrong listener. I used the new signal as argument feature to make removing the listener easier and added a test. PR-URL: https://github.com/nodejs/node/pull/36424 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-12-22lib: refactor to use more primordials in internal/histogram.jsraisinten
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/36455 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2020-12-22tools: revise line in configure.py for clarityRich Trott
* Replace unused identifier with Python convention `_`. * Remove unneeded parentheses. * Remove line-wrapping. I confirmed that this doesn't change the output by running `./configure --shared-zlib` and confirming that it created the same `common.gypi` with and without these changes. The code changed here doesn't run unless there is a `--shared-*` flag. PR-URL: https://github.com/nodejs/node/pull/36551 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
2020-12-22doc: fix AbortSignal example for stream.ReadableMichaël Zasso
PR-URL: https://github.com/nodejs/node/pull/36596 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
2020-12-22v8: fix native `serdes` constructorsExE Boss
Fixes: https://github.com/nodejs/node/issues/13326 Refs: https://github.com/nodejs/node/pull/13541 PR-URL: https://github.com/nodejs/node/pull/36549 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2020-12-22errors: eliminate all overhead for hidden callsMomtchil Momtchev
Eliminate all overhead for function calls that are to be hidden from the stack traces at the expense of reduced performance for the error case Fixes: https://github.com/nodejs/node/issues/35386 PR-URL: https://github.com/nodejs/node/pull/35644 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2020-12-22test: increase abort logic coverageMoshe vilner
PR-URL: https://github.com/nodejs/node/pull/36586 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-12-22src: remove unnecessary ToLocalChecked node_errorsDaniel Bevenius
PR-URL: https://github.com/nodejs/node/pull/36547 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-12-22tools: fix make-v8.shRichard Lau
V8's `tools/dev/v8gen.py` does not like being passed an empty string (`""`). PR-URL: https://github.com/nodejs/node/pull/36594 Refs: https://github.com/nodejs/node/pull/36099 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2020-12-21test: increase coverage for streamZiJian Liu
1. test addAbortSignal with invalid signal Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L17 2. test addAbortSignal with invalid stream Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L28 3. test addAbortSignalNoValidate with invalid signal Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L34 4. test addAbortSignalNoValidate with aborted signal Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L40 5. test Readable.from with invalid args Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/from.js.html#L31 PR-URL: https://github.com/nodejs/node/pull/36538 Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L40 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
2020-12-21build: do not run GitHub actions for draft PRsMichaël Zasso
PR-URL: https://github.com/nodejs/node/pull/35910 Fixes: https://github.com/nodejs/node/issues/35899 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
2020-12-21doc: update and run license-builder for BabelMichaël Zasso
PR-URL: https://github.com/nodejs/node/pull/36504 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2020-12-21doc: add remark about Collaborators discussion pageFrankQiu
PR-URL: https://github.com/nodejs/node/pull/36420 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-12-21lib: support BigInt in querystring.stringifyraisinten
Fixes: https://github.com/nodejs/node/issues/36080 PR-URL: https://github.com/nodejs/node/pull/36499 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
2020-12-21fs: refactor to use optional chainingZiJian Liu
PR-URL: https://github.com/nodejs/node/pull/36524 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2020-12-21tools: fix release script sign functionAntoine du Hamel
PR-URL: https://github.com/nodejs/node/pull/36556 Refs: https://github.com/nodejs/node/pull/36540 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>
2020-12-21doc: simplify worker_threads.md textRich Trott
PR-URL: https://github.com/nodejs/node/pull/36545 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
2020-12-21deps: upgrade npm to 7.3.0Ruy Adorno
PR-URL: https://github.com/nodejs/node/pull/36572 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2020-12-21tools: update ESLint to 7.16.0zhangyongsheng
PR-URL: https://github.com/nodejs/node/pull/36579 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2020-12-21tools: fix update-eslint.shzhangyongsheng
PR-URL: https://github.com/nodejs/node/pull/36579 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2020-12-21benchmark: reduce code duplicationRich Trott
Merge duplicate case code in child-process-params.js. PR-URL: https://github.com/nodejs/node/pull/36568 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
2020-12-21src: use correct microtask queue for checkpointsAnna Henningsen
I missed in c6c8337402 that we should not just use that queue for enqueuing microtasks, but also for running them. Refs: https://github.com/nodejs/node/pull/36482 PR-URL: https://github.com/nodejs/node/pull/36581 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
2020-12-21repl: disable blocking completions by defaultAnna Henningsen
It’s not okay for the REPL to be blocked for multiple seconds after entering `require('` because the completion is performing blocking fs operations on potentially huge directories. Turning the REPL completion function asynchronous would be the right thing to do here, but unfortunately the way the code is structured doesn’t play well with that (in particular, it breaks the preview feature). Therefore, disable these blocking calls by default. Refs: https://github.com/nodejs/node/pull/33282#issuecomment-733646794 PR-URL: https://github.com/nodejs/node/pull/36564 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2020-12-20stream: fix pipe deadlock when starting with needDrainRobert Nagy
Fixes: https://github.com/nodejs/node/issues/36544 PR-URL: https://github.com/nodejs/node/pull/36563 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2020-12-18build: run some workflows only on nodejs/nodeMichaël Zasso
This updates the close-stalled, comment-stalled and license-builder workflows to skip them on repositories that are not nodejs/node. PR-URL: https://github.com/nodejs/node/pull/36507 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-12-18test: increase coverage for workerZiJian Liu
test new Worker() with invalid NODE_OPTIONS Refs: https://coverage.nodejs.org/coverage-743ee9d2c05efefe/lib/internal/worker.js.html#L179 PR-URL: https://github.com/nodejs/node/pull/36491 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
2020-12-18doc: add two tips for speeding the dev buildsMomtchil Momtchev
Add two important tips for novice Node.js contributors PR-URL: https://github.com/nodejs/node/pull/36452 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2020-12-172020-12-17, Version 14.15.3 'Fermium' (LTS)Beth Griggs
Notable Changes: Node.js v14.15.2 included a commit that has caused reported breakages when cloning request objects. This release reverts the commit that introduced the behaviour change. See https://github.com/nodejs/node/issues/36550 for more details. PR-URL: https://github.com/nodejs/node/pull/36555
2020-12-18doc: add note about timingSafeEqual for TypedArrayTobias Nießen
PR-URL: https://github.com/nodejs/node/pull/36323 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
2020-12-17tools: fix release scriptAntoine du Hamel
PR-URL: https://github.com/nodejs/node/pull/36540 Refs: https://github.com/nodejs/node/pull/36123 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
2020-12-17tools: remove unused variable in configure.pyRich Trott
PR-URL: https://github.com/nodejs/node/pull/36525 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2020-12-17doc: move Derek Lewis to emeritusRich Trott
Derek informed me that he intends to take a break from collaborator-ship. PR-URL: https://github.com/nodejs/node/pull/36514 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
2020-12-17http: add test for incomingmessage destroyDaniele Belardi
Test uncaught exceptions when destroying IncomingMessage. PR-URL: https://github.com/nodejs/node/pull/33035 Refs: https://github.com/nodejs/node/issues/30625 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-12-17http: use standard args order in IncomingMEssage onErrorDaniele Belardi
PR-URL: https://github.com/nodejs/node/pull/33035 Refs: https://github.com/nodejs/node/issues/30625 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-12-17http: remove trailing spaceDaniele Belardi
PR-URL: https://github.com/nodejs/node/pull/33035 Refs: https://github.com/nodejs/node/issues/30625 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-12-17http: add comments in _http_incomingDaniele Belardi
PR-URL: https://github.com/nodejs/node/pull/33035 Refs: https://github.com/nodejs/node/issues/30625 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>