diff options
| author | Rich Trott <rtrott@gmail.com> | 2020-12-17 05:35:24 -0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2020-12-22 07:11:02 -0800 |
| commit | 083abe20b9a30b358e0ec97a1ca591e414a7dcb8 (patch) | |
| tree | d5039f4ccda073d13d3c7df40d4f2b1c33f288d9 | |
| parent | 2723d2db7e17f4e37d1e4044eb11663aaf3f742e (diff) | |
| download | ios-node-v8-083abe20b9a30b358e0ec97a1ca591e414a7dcb8.tar.gz ios-node-v8-083abe20b9a30b358e0ec97a1ca591e414a7dcb8.tar.bz2 ios-node-v8-083abe20b9a30b358e0ec97a1ca591e414a7dcb8.zip | |
tools: revise line in configure.py for clarity
* Replace unused identifier with Python convention `_`.
* Remove unneeded parentheses.
* Remove line-wrapping.
I confirmed that this doesn't change the output by running `./configure
--shared-zlib` and confirming that it created the same `common.gypi`
with and without these changes. The code changed here doesn't run unless
there is a `--shared-*` flag.
PR-URL: https://github.com/nodejs/node/pull/36551
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
| -rwxr-xr-x | configure.py | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/configure.py b/configure.py index c24d56b5d1..8ed8524b26 100755 --- a/configure.py +++ b/configure.py @@ -1347,8 +1347,7 @@ def configure_library(lib, output, pkgname=None): output['variables']['node_' + shared_lib] = b(getattr(options, shared_lib)) if getattr(options, shared_lib): - (pkg_libs, pkg_cflags, pkg_libpath, pkg_modversion) = ( - pkg_config(pkgname or lib)) + (pkg_libs, pkg_cflags, pkg_libpath, _) = pkg_config(pkgname or lib) if options.__dict__[shared_lib + '_includes']: output['include_dirs'] += [options.__dict__[shared_lib + '_includes']] |