1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
|
// Copyright 2018 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax --experimental-inline-promise-constructor
// We have to patch mjsunit because normal assertion failures just throw
// exceptions which are swallowed in a then clause.
failWithMessage = (msg) => %AbortJS(msg);
// Don't crash.
(function() {
function foo() {
let resolve, reject, promise;
promise = new Promise((a, b) => { resolve = a; reject = b; });
return {resolve, reject, promise};
}
foo();
foo();
%OptimizeFunctionOnNextCall(foo);
foo();
})();
// Check that when executor is non-callable, the constructor throws.
(function() {
function foo() {
return new Promise(1);
}
assertThrows(foo, TypeError);
assertThrows(foo, TypeError);
%OptimizeFunctionOnNextCall(foo);
assertThrows(foo, TypeError);
})();
// Check that when the promise constructor throws because the executor is
// non-callable, the stack contains 'new Promise'.
(function() {
function foo() {
return new Promise(1);
}
let threw;
try {
threw = false;
foo();
} catch (e) {
threw = true;
assertContains('new Promise', e.stack);
} finally {
assertTrue(threw);
}
try {
threw = false;
foo();
} catch (e) {
threw = true;
assertContains('new Promise', e.stack);
} finally {
assertTrue(threw);
}
%OptimizeFunctionOnNextCall(foo);
try {
threw = false;
foo();
} catch (e) {
threw = true;
assertContains('new Promise', e.stack);
} finally {
assertTrue(threw);
}
})();
// Check that when executor throws, the promise is rejected.
(function() {
function foo() {
return new Promise((a, b) => { throw new Error(); });
}
function bar(i) {
let error = null;
foo().then(_ => error = 1, e => error = e);
setTimeout(_ => assertInstanceof(error, Error));
if (i == 1) %OptimizeFunctionOnNextCall(foo);
if (i > 0) setTimeout(bar.bind(null, i - 1));
}
bar(3);
})();
// Check that when executor causes lazy deoptimization of the inlined
// constructor, we return the promise value and not the return value of the
// executor function itself.
(function() {
function foo() {
let p;
try {
p = new Promise((a, b) => { %DeoptimizeFunction(foo); });
} catch (e) {
// Nothing should throw
assertUnreachable();
}
assertInstanceof(p, Promise);
}
foo();
foo();
%OptimizeFunctionOnNextCall(foo);
foo();
})();
// The same as above, except that the executor function also creates a promise
// and both executor functions cause a lazy deopt of the calling function.
(function() {
function executor(a, b) {
%DeoptimizeFunction(foo);
let p = new Promise((a, b) => { %DeoptimizeFunction(executor); });
}
function foo() {
let p;
try {
p = new Promise(executor);
} catch (e) {
// Nothing should throw
assertUnreachable();
}
assertInstanceof(p, Promise);
}
foo();
foo();
%OptimizeFunctionOnNextCall(foo);
foo();
})();
// Check that when the executor causes lazy deoptimization of the inlined
// constructor, and then throws, the deopt continuation catches and then calls
// the reject function instead of propagating the exception.
(function() {
function foo() {
let p;
try {
p = new Promise((a, b) => {
%DeoptimizeFunction(foo);
throw new Error();
});
} catch (e) {
// The promise constructor should catch the exception and reject the
// promise instead.
// TODO(petermarshall): This fails but should not. We need to fix deopts.
// assertUnreachable();
}
// TODO(petermarshall): This fails but should not.
// assertInstanceof(p, Promise);
}
foo();
foo();
%OptimizeFunctionOnNextCall(foo);
foo();
})();
// Test when the executor is not inlined.
(function() {
let resolve, reject, promise;
function bar(a, b) {
resolve = a; reject = b;
throw new Error();
}
function foo() {
promise = new Promise(bar);
}
foo();
foo();
%NeverOptimizeFunction(bar);
%OptimizeFunctionOnNextCall(foo);
foo();
})();
// Test that the stack trace contains 'new Promise'
(function() {
let resolve, reject, promise;
function bar(a, b) {
resolve = a; reject = b;
let stack = new Error().stack;
assertContains("new Promise", stack);
throw new Error();
}
function foo() {
promise = new Promise(bar);
}
foo();
foo();
%OptimizeFunctionOnNextCall(foo);
foo();
})();
|
