1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
|
'use strict'
const cacheFile = require('npm-cache-filename')
const mkdirp = require('mkdirp')
const mr = require('npm-registry-mock')
const osenv = require('osenv')
const path = require('path')
const qs = require('querystring')
const rimraf = require('rimraf')
const test = require('tap').test
const Tacks = require('tacks')
const File = Tacks.File
const common = require('../common-tap.js')
const PKG_DIR = path.resolve(__dirname, 'search')
const CACHE_DIR = path.resolve(PKG_DIR, 'cache')
const cacheBase = cacheFile(CACHE_DIR)(common.registry + '/-/all')
const cachePath = path.join(cacheBase, '.cache.json')
let server
test('setup', function (t) {
mr({port: common.port, throwOnUnmatched: true}, function (err, s) {
t.ifError(err, 'registry mocked successfully')
server = s
t.pass('all set up')
t.done()
})
})
test('notifies when there are no results', function (t) {
setup()
const query = qs.stringify({
text: 'none',
size: 20,
quality: 0.65,
popularity: 0.98,
maintenance: 0.5
})
server.get(`/-/v1/search?${query}`).once().reply(200, {
objects: []
})
common.npm([
'search', 'none',
'--registry', common.registry,
'--loglevel', 'error'
], {}, function (err, code, stdout, stderr) {
if (err) throw err
t.equal(stderr, '', 'no error output')
t.equal(code, 0, 'search gives 0 error code even if no matches')
t.match(stdout, /No matches found/, 'Useful message on search failure')
t.done()
})
})
test('spits out a useful error when no cache nor network', function (t) {
setup()
const query = qs.stringify({
text: 'foo',
size: 20,
quality: 0.65,
popularity: 0.98,
maintenance: 0.5
})
server.get(`/-/v1/search?${query}`).once().reply(404, {})
server.get('/-/all').many().reply(404, {})
const cacheContents = {}
const fixture = new Tacks(File(cacheContents))
fixture.create(cachePath)
common.npm([
'search', 'foo',
'--registry', common.registry,
'--loglevel', 'silly',
'--json',
'--fetch-retry-mintimeout', 0,
'--fetch-retry-maxtimeout', 0,
'--cache', CACHE_DIR
], {}, function (err, code, stdout, stderr) {
if (err) throw err
t.equal(code, 1, 'non-zero exit code')
t.match(JSON.parse(stdout).error.summary, /No search sources available/)
t.match(stderr, /No search sources available/, 'useful error')
t.done()
})
})
test('can switch to JSON mode', function (t) {
setup()
const query = qs.stringify({
text: 'oo',
size: 20,
quality: 0.65,
popularity: 0.98,
maintenance: 0.5
})
server.get(`/-/v1/search?${query}`).once().reply(200, {
objects: [
{ package: { name: 'cool', version: '1.0.0' } },
{ package: { name: 'foo', version: '2.0.0' } }
]
})
common.npm([
'search', 'oo',
'--json',
'--registry', common.registry,
'--loglevel', 'error',
'--cache', CACHE_DIR
], {}, function (err, code, stdout, stderr) {
if (err) throw err
t.equal(stderr, '', 'no error output')
t.equal(code, 0, 'search gives 0 error code even if no matches')
t.similar(JSON.parse(stdout), [
{
name: 'cool',
version: '1.0.0'
},
{
name: 'foo',
version: '2.0.0'
}
], 'results returned as valid json')
t.done()
})
})
test('JSON mode does not notify on empty', function (t) {
setup()
const query = qs.stringify({
text: 'oo',
size: 20,
quality: 0.65,
popularity: 0.98,
maintenance: 0.5
})
server.get(`/-/v1/search?${query}`).once().reply(200, {
objects: []
})
common.npm([
'search', 'oo',
'--json',
'--registry', common.registry,
'--loglevel', 'error',
'--cache', CACHE_DIR
], {}, function (err, code, stdout, stderr) {
if (err) throw err
t.deepEquals(JSON.parse(stdout), [], 'no notification about no results')
t.equal(stderr, '', 'no error output')
t.equal(code, 0, 'search gives 0 error code even if no matches')
t.done()
})
})
test('can switch to tab separated mode', function (t) {
setup()
const query = qs.stringify({
text: 'oo',
size: 20,
quality: 0.65,
popularity: 0.98,
maintenance: 0.5
})
server.get(`/-/v1/search?${query}`).once().reply(200, {
objects: [
{ package: { name: 'cool', version: '1.0.0' } },
{ package: { name: 'foo', description: 'this\thas\ttabs', version: '2.0.0' } }
]
})
common.npm([
'search', 'oo',
'--parseable',
'--registry', common.registry,
'--loglevel', 'error',
'--cache', CACHE_DIR
], {}, function (err, code, stdout, stderr) {
if (err) throw err
t.equal(stdout, 'cool\t\t\tprehistoric\t1.0.0\t\nfoo\tthis has tabs\t\tprehistoric\t2.0.0\t\n', 'correct output, including replacing tabs in descriptions')
t.equal(stderr, '', 'no error output')
t.equal(code, 0, 'search gives 0 error code even if no matches')
t.done()
})
})
test('tab mode does not notify on empty', function (t) {
setup()
const query = qs.stringify({
text: 'oo',
size: 20,
quality: 0.65,
popularity: 0.98,
maintenance: 0.5
})
server.get(`/-/v1/search?${query}`).once().reply(200, {
objects: []
})
common.npm([
'search', 'oo',
'--parseable',
'--registry', common.registry,
'--loglevel', 'error',
'--cache', CACHE_DIR
], {}, function (err, code, stdout, stderr) {
if (err) throw err
t.equal(stdout, '', 'no notification about no results')
t.equal(stderr, '', 'no error output')
t.equal(code, 0, 'search gives 0 error code even if no matches')
t.done()
})
})
test('no arguments provided should error', function (t) {
cleanup()
common.npm(['search'], {}, function (err, code, stdout, stderr) {
if (err) throw err
t.equal(code, 1, 'search finished unsuccessfully')
t.match(
stderr,
/search must be called with arguments/,
'should have correct error message'
)
t.end()
})
})
test('cleanup', function (t) {
cleanup()
server.close()
t.end()
})
function setup () {
cleanup()
mkdirp.sync(cacheBase)
}
function cleanup () {
server.done()
process.chdir(osenv.tmpdir())
rimraf.sync(PKG_DIR)
}
|
