aboutsummaryrefslogtreecommitdiff
path: root/test/parallel/parallel.status
AgeCommit message (Collapse)Author
2019-11-29test: revert 6d022c13Anna Henningsen
Revert "test: skip test-domain-error-types in debug mode temporariliy" This reverts commit 6d022c13c52fc0134ed6c79be520be8c84c58cf8. PR-URL: https://github.com/nodejs/node/pull/30708 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
2019-11-26test: skip test-domain-error-types in debug mode temporariliyRich Trott
Until https://github.com/nodejs/node/issues/30498 is resolved, skip test-domain-error-types on debug builds. PR-URL: https://github.com/nodejs/node/pull/30629 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
2019-11-15test: deflake test-http-dump-req-when-res-ends.jsLuigi Pinca
On some platforms the `'end'` event might not be emitted because the socket could be destroyed by the other peer while the client is still sending the data triggering an error. Use the `'close'` event instead. PR-URL: https://github.com/nodejs/node/pull/30360 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2019-11-11test: mark test-http-dump-req-when-res-ends as flaky on windowsAshCripps
PR-URL: https://github.com/nodejs/node/pull/30316 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2019-09-12test: unmark test-worker-prof as flakyAnna Henningsen
This has no longer been flaky since V8 7.5. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9333 Fixes: https://github.com/nodejs/node/issues/26401 PR-URL: https://github.com/nodejs/node/pull/29511 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2019-07-04test: unmark test-gc-http-client-onerror flakyRich Trott
The test has not failed on FreeBSD in the last 100 runs and appears to perhaps not be an issue anymore. Closes: https://github.com/nodejs/node/issues/23089 test-gc-http-client-onerror: PASS,FLAKY PR-URL: https://github.com/nodejs/node/pull/28429 Fixes: https://github.com/nodejs/node/issues/23089 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2019-06-20test: fix flaky test-worker-debugAnna Henningsen
Address a race condition in the test; the Worker’s exit events may have been not recorded because the Worker exited before the listeners were attached. Fix the by attaching the event listeners before telling the Worker to exit. PR-URL: https://github.com/nodejs/node/pull/28307 Fixes: https://github.com/nodejs/node/issues/28299 Fixes: https://github.com/nodejs/node/issues/28106 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
2019-06-14test: skip `test-worker-prof` as flaky for allMilad Farazmand
Due to a bug in V8 GC, this test case has to potential to fail on all platforms. V8 master has been patched with a fix and waiting for it to be backported to V8 7.5 and 7.6. Skipping the test until it is backported. Bug can be tracked here: https://bugs.chromium.org/p/v8/issues/detail?id=9333 PR-URL: https://github.com/nodejs/node/pull/28175 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2019-06-12test: mark test-fs-stat-bigint as flakyRich Trott
Refs: https://github.com/nodejs/node/issues/24593 PR-URL: https://github.com/nodejs/node/pull/28156 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
2019-06-10test: add github refs to flaky testsSam Roberts
PR-URL: https://github.com/nodejs/node/pull/28123 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2019-06-06test: mark test-worker-debug as flakyRefael Ackermann
Also try to make more traceable. PR-URL: https://github.com/nodejs/node/pull/28035 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
2019-06-06test: only assert on first lines of TLS traceSam Roberts
The TLS trace data is best-effort, and enough can be dropped from pipe buffers that only the start of the trace is detected. Only assert on the first line of the trace, it should not get dropped, and it's enough to check that trace was enabled via CLI. PR-URL: https://github.com/nodejs/node/pull/28043 Fixes: https://github.com/nodejs/node/issues/27636 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2019-05-17test: un-mark worker syntax error tests as flakyAnna Henningsen
These tests should be fixed now. PR-URL: https://github.com/nodejs/node/pull/27705 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2019-05-06test: deflake test-tls-js-streamLuigi Pinca
`socket.destroy()` can destory the stream before the chunk to write with `socket.end()` is actually sent. Furthermore `socket.destroy()` destroys `p` and not the actual raw socket. As a result it is possible that the connection is left open. Remove `socket.destroy()` to ensure that the chunk is sent. Also use `common.mustCall()` to ensure that the `'secureConnection'` and `'secureConnect'` events are emitted exactly once. PR-URL: https://github.com/nodejs/node/pull/27478 Fixes: https://github.com/nodejs/node/issues/26938 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
2019-05-06test: mark test-tls-enable-trace-cli flakycjihrig
PR-URL: https://github.com/nodejs/node/pull/27559 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2019-05-02test: refactor and deflake test-tls-sni-server-clientLuigi Pinca
- Run all tests in parallel. - Move `socket.end()` call to client. - Use `common.mustCall()` and `common.mustNotCall()`. Fixes: https://github.com/nodejs/node/issues/27219 Refs: https://github.com/nodejs/node/pull/27300 PR-URL: https://github.com/nodejs/node/pull/27426 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2019-04-30test: remove flaky designation for test-tls-sni-optionLuigi Pinca
Refs: https://github.com/nodejs/node/pull/27300 PR-URL: https://github.com/nodejs/node/pull/27425 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2019-04-21test: mark some known flakesRefael Ackermann
PR-URL: https://github.com/nodejs/node/pull/27225 Refs: https://github.com/nodejs/node/issues/26910 Refs: https://github.com/nodejs/node/issues/27219 Refs: https://github.com/nodejs/node/issues/26938 Refs: https://github.com/nodejs/node/issues/23089 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
2019-04-21test: remove flaky designation for test-cli-node-optionsRich Trott
The test failure is not platform-specific and is the result of manual/human error. Some improvements may be possible, but there is nothing fundamentally unsound about the test insofar as when it fails in CI, there is a problem on the host that needs to be addressed and not an inherent issue with the test. Refs: https://github.com/nodejs/node/issues/25028#issuecomment-479554080 Closes: https://github.com/nodejs/node/issues/25028 PR-URL: https://github.com/nodejs/node/pull/27305 Fixes: https://github.com/nodejs/node/issues/25028 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2019-04-11test: mark some known flakesRefael Ackermann
PR-URL: https://github.com/nodejs/node/pull/27193 Refs: https://github.com/nodejs/node/issues/20750 Refs: https://github.com/nodejs/node/issues/26610 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
2019-04-02test: remove test-trace-events-api-worker-disabled from flakyRich Trott
PR-URL: https://github.com/nodejs/node/pull/27020 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2019-03-11test: mark test-worker-prof as flake on all platformsRefael Ackermann
PR-URL: https://github.com/nodejs/node/pull/26600 Refs: https://github.com/nodejs/node/issues/26401 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
2019-03-10test: mark `test-worker-prof` as Flaky on ARMRefael Ackermann
PR-URL: https://github.com/nodejs/node/pull/26557 Refs: https://github.com/nodejs/node/issues/26401 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2019-01-23test: revoke flaky designation for testsGireesh Punathil
A number of tests that were `flaked` recently are proved to have failing reason identified in https://github.com/nodejs/node/issues/25007 and resolution identified in https://github.com/nodejs/node/pull/25061 Revoke flaky designation of all these tests as the said PR is landed. PR-URL: https://github.com/nodejs/node/pull/25611 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
2019-01-01test: mark test-util-callbackify flaky on AIXRich Trott
Refs: https://github.com/nodejs/node/issues/25068 PR-URL: https://github.com/nodejs/node/pull/25284 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2018-12-28test: mark two tests as flaky in AIXGireesh Punathil
sequential/test-inspector-debug-end and parallel/test-child-process-execfile Off late these have been failing in AIX. Debugging core dump suggested that this is a side effect of exit-race that is described in https://github.com/nodejs/node/issues/25007 Mart these as flaky in AIX until that is resolved. Refs: https://github.com/nodejs/node/issues/25047 Refs: https://github.com/nodejs/node/issues/25029 PR-URL: https://github.com/nodejs/node/pull/25126 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2018-12-24test: mark test-trace-events-api-worker-disabled flakyRich Trott
Refs: https://github.com/nodejs/node/issues/24305 PR-URL: https://github.com/nodejs/node/pull/25197 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2018-12-14test: mark test-child-process-execfile flakyRich Trott
Refs: https://github.com/nodejs/node/issues/25029 PR-URL: https://github.com/nodejs/node/pull/25051 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
2018-12-14test: mark test-child-process-exit-code flakyRich Trott
Refs: # https://github.com/nodejs/node/issues/25033 PR-URL: https://github.com/nodejs/node/pull/25050 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
2018-12-14test: mark test-worker-memory flaky on Windows CIRich Trott
Refs: https://github.com/nodejs/node/issues/23277 PR-URL: https://github.com/nodejs/node/pull/25042 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
2018-12-14test: mark test-cli-node-options flaky on armRich Trott
Refs: https://github.com/nodejs/node/issues/25028 PR-URL: https://github.com/nodejs/node/pull/25032 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
2018-12-11stream: fix end-of-stream for HTTP/2Anna Henningsen
HTTP/2 streams call `.end()` on themselves from their `.destroy()` method, which might be queued (e.g. due to network congestion) and not processed before the stream itself is destroyed. In that case, the `_writableState.ended` property could be set before the stream emits its `'close'` event, and never actually emits the `'finished'` event, confusing the end-of-stream implementation so that it wouldn’t call its callback. This can be fixed by watching for the end events themselves using the existing `'finish'` and `'end'` listeners rather than relying on the `.ended` properties of the `_...State` objects. These properties still need to be checked to know whether stream closure was premature – My understanding is that ideally, streams should not emit `'close'` before `'end'` and/or `'finished'`, so this might be another bug, but changing this would require modifying tests and almost certainly be a breaking change. Fixes: https://github.com/nodejs/node/issues/24456 PR-URL: https://github.com/nodejs/node/pull/24926 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
2018-11-24test: split out http2 from test-stream-pipelineRich Trott
Splitting out the http2 portion of the test has a few benfits: * We don't skip the rest of the tests if `node` is compiled without crypto. * We can find out if the http2 portion of the test is responsible for the timeouts reported in issue 24456. Refs: https://github.com/nodejs/node/issues/24456 PR-URL: https://github.com/nodejs/node/pull/24631 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2018-10-06test: remove flaky designation for testRich Trott
Unreliability for test-trace-events-fs-sync is believed to have been fixed. Remove flaky designation. Ref: https://github.com/nodejs/node/pull/22812 Ref: https://github.com/nodejs/node/issues/21038#issuecomment-421199960 PR-URL: https://github.com/nodejs/node/pull/22856 Refs: https://github.com/nodejs/node/pull/22812 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Refael Ackermann <refack@gmail.com>
2018-10-02test: mark some flakesRefael Ackermann
PR-URL: https://github.com/nodejs/node/pull/23208 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2018-09-19test: mark some tests as flakyJoão Reis
Refs: https://github.com/nodejs/node/issues/20750 Refs: https://github.com/nodejs/node/issues/22327 Refs: https://github.com/nodejs/node/issues/22762 Refs: https://github.com/nodejs/reliability/issues/16 PR-URL: https://github.com/nodejs/node/pull/22941 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
2018-08-24test: flaky everywhere test-trace-events-fs-syncRefael Ackermann
Refs: https://github.com/nodejs/node/issues/21038 PR-URL: https://github.com/nodejs/node/pull/22483 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2018-06-07child_process: swallow errors in internal communicationAnatoli Papirovski
Much like with NODE_HANDLE_ACK, the internal protocol for communication about the sent socket should not expose its errors to the users when those async calls are not initiated by them. PR-URL: https://github.com/nodejs/node/pull/21108 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
2018-06-06test: create new directory v8-updatesMatheus Marchini
`v8-updates` holds all tests related to V8 updates, for example, testing for postmortem metadata chages. PR-URL: https://github.com/nodejs/node/pull/20783 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2018-06-05test: refactor child-process-fork-netRich Trott
Split test-child-process-fork-net into test-child-process-fork-net-server and test-child-process-fork-net-socket. Rename test-child-process-fork-net2.js to test-child-process-fork-net.js. Refs: https://github.com/nodejs/node/pull/21012 PR-URL: https://github.com/nodejs/node/pull/21095 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2018-06-04test: mark test-trace-events-fs-sync as flakyMatheus Marchini
test-trace-events-fs-sync has been failing ocasinally on FreeBSD. While we don't have a fix, it should be marked as flaky. Ref: https://github.com/nodejs/node/issues/21038 PR-URL: https://github.com/nodejs/node/pull/21039 Refs: https://github.com/nodejs/node/issues/21038 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Lance Ball <lball@redhat.com>
2018-05-30test: mark test-child-process-fork-net as flakyMatheus Marchini
`flaky-test-child-process-fork-net` has been failing constantly for the past few days, and all solutions suggestes so far were didn't work. Marking it as faky while the issue is not fixed. Ref: https://github.com/nodejs/node/pull/21012 Ref: https://github.com/nodejs/node/pull/20973 Ref: https://github.com/nodejs/node/pull/20973 PR-URL: https://github.com/nodejs/node/pull/21018 Refs: https://github.com/nodejs/node/pull/21012 Refs: https://github.com/nodejs/node/pull/20973 Refs: https://github.com/nodejs/node/pull/20973 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2018-05-22http2: fix several serious bugsAnatoli Papirovski
Currently http2 does not properly submit GOAWAY frames when a session is being destroyed. It also doesn't properly handle when the other party severs the connection after sending a GOAWAY frame, even though it should. Edge, IE & Safari are currently unable to handle empty TRAILERS frames despite them being correctly to spec. Instead send an empty DATA frame with END_STREAM flag in those situations. Fix and adjust several flaky and/or incorrect tests. PR-URL: https://github.com/nodejs/node/pull/20772 Fixes: https://github.com/nodejs/node/issues/20705 Fixes: https://github.com/nodejs/node/issues/20750 Fixes: https://github.com/nodejs/node/issues/20850 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2018-05-19test: mark tests as flaky as intermediate stepRuben Bridgewater
We have a few http2 issues that are currently resolved. Until they are, just mark these two tests as flaky. PR-URL: https://github.com/nodejs/node/pull/20835 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
2018-03-10test: remove flaky status for test-npm-installRich Trott
I haven't seen test-npm-install fail on arm in a long time. There is no open issue for it being unreliable. Remove flaky designation in parallel.status file. (If it turns out it is flaky, it's easy enough to open an issue and restore the flaky designation.) Ref: https://github.com/nodejs/node/issues/13498 PR-URL: https://github.com/nodejs/node/pull/19216 Refs: https://github.com/nodejs/node/issues/13498 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2017-12-18test: add test for postmortem metadata validationcjihrig
This commit adds a test to validate postmortem debugging metadata. When this test runs, it can check for the presence of metadata constants used by tools such as llnode and mdb and report if any have accidentally been removed. PR-URL: https://github.com/nodejs/node/pull/17685 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
2017-11-11test: unmark flaky testAnna Henningsen
This effectively reverts 5c475a722357b1d4ddf099992e3f5df7e51583e1 and 75095d700137e29ad1413972b8f6eed7c3473a65. PR-URL: https://github.com/nodejs/node/pull/16758 Fixes: https://github.com/node/issues/16210 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2017-11-03http2: allocate on every chunk sendJames M Snell
Previously, we were using a shared stack allocated buffer to hold the serialized outbound data but that runs into issues if the outgoing stream does not write or copy immediately. Instead, allocate a buffer each time. Slight additional overhead here, but necessary. Later on, once we've analyzed this more, we might be able to switch to a stack allocated ring or slab buffer but that's a bit more complicated than what we strictly need right now. PR-URL: https://github.com/nodejs/node/pull/16669 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2017-11-02test: fix malformed parallel.status lineRich Trott
PR-URL: https://github.com/nodejs/node/pull/16702 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
2017-11-02test: mark test-async-wrap-uncaughtexception as flakyRefael Ackermann
`parallel/test-async-wrap-uncaughtexception.js` has become flaky. At this time investigating the cause is still on going, but this issue become has prevalent. In order to restore CI status to be relevant, this marks the test as explicitly FLAKY. PR-URL: https://github.com/nodejs/node/pull/16694 Refs: https://github.com/nodejs/node/issues/16210 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-16 00:26:34 +0000