diff options
| author | James M Snell <jasnell@gmail.com> | 2017-11-01 11:11:34 -0700 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2017-11-03 10:27:43 -0700 |
| commit | 4db1bc8f2052a1cd2bab267e026b5ee330f25aad (patch) | |
| tree | 9ba1a4949116a67ab722618aef7c679a9183e543 /test/parallel/parallel.status | |
| parent | de246028cbfe0d858cbee7b39ff17acc13a3ceb4 (diff) | |
| download | android-node-v8-4db1bc8f2052a1cd2bab267e026b5ee330f25aad.tar.gz android-node-v8-4db1bc8f2052a1cd2bab267e026b5ee330f25aad.tar.bz2 android-node-v8-4db1bc8f2052a1cd2bab267e026b5ee330f25aad.zip | |
http2: allocate on every chunk send
Previously, we were using a shared stack allocated buffer to hold
the serialized outbound data but that runs into issues if the
outgoing stream does not write or copy immediately. Instead,
allocate a buffer each time. Slight additional overhead here,
but necessary.
Later on, once we've analyzed this more, we might be able to
switch to a stack allocated ring or slab buffer but that's a
bit more complicated than what we strictly need right now.
PR-URL: https://github.com/nodejs/node/pull/16669
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'test/parallel/parallel.status')
| -rw-r--r-- | test/parallel/parallel.status | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status index 32b72b3a8d..bdd9a3961a 100644 --- a/test/parallel/parallel.status +++ b/test/parallel/parallel.status @@ -20,7 +20,5 @@ test-npm-install: PASS,FLAKY [$system==solaris] # Also applies to SmartOS [$system==freebsd] -test-http2-compat-serverrequest-pipe: PASS,FLAKY -test-http2-pipe: PASS,FLAKY [$system==aix] |