summaryrefslogtreecommitdiff
path: root/Makefile
AgeCommit message (Collapse)Author
2019-12-02build,win: add test-ci-native and test-ci-jsJoão Reis
PR-URL: https://github.com/nodejs/node/pull/30724 Refs: https://github.com/nodejs/build/issues/1996 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2019-11-30tools: add unified plugin changing links for html docsMarek Łabuz
This commit introduces additional stage in the process of generating html docs from markdown files. Plugin transforms links to *.md files in the respository to links to *.html files in the online documentation. Fixes: https://github.com/nodejs/node/issues/28689 PR-URL: https://github.com/nodejs/node/pull/29946 Reviewed-By: Anna Henningsen <anna@addaleax.net>
2019-11-11test: fix Python unittests in ./test and ./toolscclauss
Co-authored-by: @patrickhousley Fixes to Python tests to ensure that the following all pass: 1. __python2 -m pytest ./test ./tools__ # 30 tests pass 2. __python3 -m pytest ./test ./tools__ # 30 tests pass 3. __python2 -m unittest discover -s ./test/tools__ # 1 test passes 4. __python3 -m unittest discover -s ./test/tools__ # 1 test passes 5. __PYTHON=python2 make tooltest__ # 1 test passes 6. __PYTHON=python3 make tooltest__ # 1 test passes This is a subset of #30033 PR-URL: https://github.com/nodejs/node/pull/30340 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com>
2019-11-06Revert "test: test configure ninja"Anna Henningsen
This reverts commit 85dd9e8333f227dcdcbe86ae45f239a2b5cef030. `make test` should never change the current set of `configure` flags. Refs: https://github.com/nodejs/node/pull/30033 PR-URL: https://github.com/nodejs/node/pull/30295 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2019-11-05test: test configure ninjaPatrick Housley
- Updated the tooltest target to run unittest module - Renamed test/tools/test-js2c.py to be discoverable by unittest module - Added test class for `configure` shell script - Added a test to ensure `configure` script exits with status code zero when passed the `--ninja` flag Closes: https://github.com/nodejs/node/issues/29415 PR-URL: https://github.com/nodejs/node/pull/30033 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
2019-10-22build: make linter failures fail `test-doc` targetRichard Lau
Linter failures in the `test-doc` make target were not failing the build if the subsequent `doctools` test passed as its exit code wasn't being preserved. Make the `lint` target a dependency of `test-doc` so that it is outside of the `node_use_openssl` guard -- its own dependencies have their own guards where necessary and the targets that don't require an available node (e.g. the C++ linters) will be allowed to run. PR-URL: https://github.com/nodejs/node/pull/30012 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
2019-10-17build: build benchmark addons like test addonsRichard Lau
Build the addons for benchmarks in the same way that the addons for tests are built. PR-URL: https://github.com/nodejs/node/pull/29995 Fixes: https://github.com/nodejs/build/issues/1961 Refs: https://github.com/nodejs/node/commit/53ca0b9ae145c430842bf78e553e3b6cbd2823aa#commitcomment-35494896 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2019-10-10build: make full-icu the default for releasesRichard Lau
Release builds specifically set the `--with-intl=` configure option instead of relying on the default. Explicitly set to `full-icu`. Refs: https://github.com/nodejs/node/pull/29522 PR-URL: https://github.com/nodejs/node/pull/29887 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2019-09-28build: include deps/v8/test/torque in source tarballRichard Lau
Builds from the source tarball were broken by the recent V8 upate to 7.7 as a file needed to build torque wasn't included in the source tarball as it resides in deps/v8/test. PR-URL: https://github.com/nodejs/node/pull/29712 Fixes: https://github.com/nodejs/node/issues/29709 Refs: https://github.com/nodejs/node/pull/28918 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
2019-09-22build: do not indent assignments in MakefileJoyee Cheung
Indented assignment in a Makefile can be interpreted as a command in e.g. GNU Make 3.81 which results in the following error: ``` make: CPPLINT_QUIET: No such file or directory ``` PR-URL: https://github.com/nodejs/node/pull/29623 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2019-09-20http: remove legacy parserAnna Henningsen
Remove the legacy `http_parser` implementation as a dependency and all code that uses it in favor of llhttp, given that the latter has been the default for all of Node 12 with no outstanding issues. PR-URL: https://github.com/nodejs/node/pull/29589 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2019-09-12build: re-run configure on node_version.h changeAnna Henningsen
Fixes: https://github.com/nodejs/node/issues/29509 PR-URL: https://github.com/nodejs/node/pull/29510 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
2019-09-10build: improve `make coverage`Anna Henningsen
Run cleanup for all relevant subdirectories, and exclude generated source files (e.g. `out/Release/...`) from coverage reporting. Also enable running `make cctest` again (It’s unclear to me why this was disabled, as it does reduce coverage unnecessarily). PR-URL: https://github.com/nodejs/node/pull/29487 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2019-08-30build: hard code doctool in test-doc targetDaniel Bevenius
This commit removes the usage of the CI_DOC variable in the test-doc recipe and specifies the doctool argument to tools/test.py explicitly. The motivation for this is that the build is taking longer time and this is mostly due to tests being run twice as the CI_DOC variable will be empty in most cases (when not using --without-ssl). This change was introduced with/after Commit 9039af83a33af870a074463a0e8d79a0cb95d14c ("build: skip test-ci doc targets if no crypto") and while I though it might make sense to change the setting of CI_DOC I not sure about the implications that might have to our CI environment. It currently looks like this: ifeq ($(node_use_openssl), false) CI_DOC := doctool else CI_DOC = endif Which is setting CI_DOC to doctool if there is no crypto support which not available. But perhaps this should be be the other way around, changing the order or updating condition to be true. PR-URL: https://github.com/nodejs/node/pull/29375 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2019-08-23build: move tooltest to before jstest targetDaniel Bevenius
This commit moves the tooltest target to come before the jstest target to make the console output consistent with it was before I introduced the tooltest target. Currently the output looks like this which is might give the impression that only one test was run: /Applications/Xcode.app/Contents/Developer/usr/bin/make -s tooltest . ---------------------------------------------------------------------- Ran 1 test in 0.000s Compared to the usual: [03:58|% 100|+ 2739|- 0]: Done PR-URL: https://github.com/nodejs/node/pull/29220 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
2019-08-18build: remove unused optionRich Trott
There is no longer a need to skip sequential/test-benchmark-napi because it no longer resides in sequential. Benchmark tests are now in their own directory. PR-URL: https://github.com/nodejs/node/pull/29173 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2019-08-16build: add a testclean targetDaniel Bevenius
This commit adds a target named testclean to allow for cleaning the temporary files generated during a test run without having to use the clean target. PR-URL: https://github.com/nodejs/node/pull/29094 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2019-08-12tools: allow single JS file for --link-moduleDaniel Bevenius
The description for the --link-module configuration option is as follows: $ ./configure --help | grep -A 5 'link-module' --link-module=LINKED_MODULE Path to a JS file to be bundled in the binary as a builtin. This module will be referenced by path without extension; e.g. /root/x/y.js will be referenced via require('root/x/y'). Can be used multiple times This lead me to think that it was possible to specify a file like this: $ ./configure --link-module=something.js $ NODE_DEBUG=mkcodecache make -j8 This will lead to a compilation error as an entry in the source_ map in node_javascript.cc will end up having an empty string as its key: source_.emplace("", UnionBytes{_raw, 105}); This will then be used by CodeCacheBuilder when it iterates over the module ids, which will lead to the following compilation errors: /node/out/Release/obj/gen/node_code_cache.cc:12:23: warning: ISO C++17 does not allow a decomposition group to be empty [-Wempty-decomposition] static const uint8_t [] = { ^ /node/out/Release/obj/gen/node_code_cache.cc:12:22: warning: decomposition declarations are a C++17 extension [-Wc++17-extensions] static const uint8_t [] = { ^~ /node/out/Release/obj/gen/node_code_cache.cc:12:1: error: decomposition declaration cannot be declared 'static' static const uint8_t [] = { ^~~~~~ /node/out/Release/obj/gen/node_code_cache.cc:12:22: error: decomposition declaration cannot be declared with type 'const uint8_t' (aka 'const unsigned char'); declared type must be 'auto' or reference to 'auto' static const uint8_t [] = { ^ /node/out/Release/obj/gen/node_code_cache.cc:12:22: error: excess elements in scalar initializer static const uint8_t [] = { ^ /node/out/Release/obj/gen/node_code_cache.cc:660:7: error: expected expression , ^ /node/out/Release/obj/gen/node_code_cache.cc:661:24: error: no matching function for call to 'arraysize' static_cast<int>(arraysize()), policy ^~~~~~~~~ ../src/util.h:667:18: note: candidate function template not viable: requires 1 argument, but 0 were provided constexpr size_t arraysize(const T (&)[N]) { ^ 2 warnings and 5 errors generated. This commit suggests that passing a single file be allowed by modifying tools/js2c.py. PR-URL: https://github.com/nodejs/node/pull/28443 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2019-07-30build: do not mix spaces and tabs in MakefileLuigi Pinca
PR-URL: https://github.com/nodejs/node/pull/28881 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2019-07-24build: `uname -m` is amd64 on freebsd, not x86_64Ben Noordhuis
Fixes: https://github.com/nodejs/node/issues/13150 PR-URL: https://github.com/nodejs/node/pull/28804 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2019-07-22tools: remove unused pkgsrc directoryMichaël Zasso
The pkgsrc Makefile target was removed in 2015 Refs: https://github.com/nodejs/node/pull/1938 PR-URL: https://github.com/nodejs/node/pull/28783 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>
2019-07-20build: skip test-ci doc targets if no cryptoRod Vagg
PR-URL: https://github.com/nodejs/node/pull/28747 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2019-06-17build: guard test-doc recipe with node_use_opensslDaniel Bevenius
Currently, when configuring --without-ssl the test-doc target fails with the following error: /node/test/common/index.js:707 const crashOnUnhandledRejection = (err) => { throw err; }; ^ Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support at Object.assertCrypto (internal/util.js:97:11) at https.js:26:26 at NativeModule.compile (internal/bootstrap/loaders.js:300:5) ... at /node/tools/doc/versions.js:7:19 at new Promise (<anonymous>) at getUrl (/node/tools/doc/versions.js:6:10) Command: out/Release/node /node/test/doctool/test-doctool-html.js [00:02|% 100|+ 3|- 1]: Done make: *** [test-doc] Error 1 This commit guards the test-doc recipe to not run if node was configured without crypto support. PR-URL: https://github.com/nodejs/node/pull/28199 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2019-06-12build: lint all docs under docRichard Lau
`**` expansion doesn't behave as expected and as a result files in nested subdirectories under `doc` were not linted. Use `find` instead to generate the list of files to lint. PR-URL: https://github.com/nodejs/node/pull/28128 Refs: https://github.com/nodejs/node/pull/28127 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2019-05-02build: delegate building from Makefile to ninjaRefael Ackermann
PR-URL: https://github.com/nodejs/node/pull/27504 Refs: https://mobile.twitter.com/refack/status/1118484079077482498 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
2019-04-23tools: implement node_mksnapshotJoyee Cheung
Implements a node_mksnapshot target that generates a snapshot blob from a Node.js main instance's isolate, and serializes the data blob with other additional data into a C++ file that can be embedded into the Node.js binary. PR-URL: https://github.com/nodejs/node/pull/27321 Refs: https://github.com/nodejs/node/issues/17058 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2019-04-22deps,test: bump googletest to 39f72ea6f5Refael Ackermann
Refs: https://github.com/google/googletest/tree/39f72ea6f5cd458860b563d7bcb7ea67546e6ea3 PR-URL: https://github.com/nodejs/node/pull/27231 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
2019-04-16build: run `mkcodecache` as an actionRefael Ackermann
* fix test-code-cache (for the common cases) * deprecate `configure --code-cache-path` PR-URL: https://github.com/nodejs/node/pull/27161 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2019-04-16tools: implement mkcodecache as an executableJoyee Cheung
This patch implement a mkcodecache executable on top of the `NativeModuleLoader` singleton. This makes it possible to build a Node.js binary with embedded code cache without building itself using the code cache stub - the cache is now initialized by `NativeModuleEnv` instead which can be refactored out of the mkcodecache dependencies. PR-URL: https://github.com/nodejs/node/pull/27161 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2019-03-28build,deps: move gypfiles out 2/2 - movingRefael Ackermann
* move all used files to `tools/v8_gypfiles` directory * fix references in node configuration PR-URL: https://github.com/nodejs/node/pull/26685 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
2019-03-21build,meta: quiet/pretty make output by defaultRefael Ackermann
PR-URL: https://github.com/nodejs/node/pull/26740 Refs: https://github.com/nodejs/node/pull/26252 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2019-03-07Revert "build: silence cpp lint by default"Refael Ackermann
This reverts commit 0373836b390999644d116c96b41ba05a8a0f181a. PR-URL: https://github.com/nodejs/node/pull/26358 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2019-02-28build: silence cpp lint by defaultRuben Bridgewater
The cpp linter is very noisy at the moment. So use the --quiet flag by default instead of being verbose in this case. PR-URL: https://github.com/nodejs/node/pull/26252 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2019-02-21build,test: guard eslint with crypto checkDaniel Bevenius
Currently, configuring --without-ssl will cause the lint-js target to fail with the following error: $ make lint-js Running JS linter... internal/util.js:101 throw new ERR_NO_CRYPTO(); ^ Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support at assertCrypto (internal/util.js:101:11) at crypto.js:31:1 ... (/node/tools/node_modules/eslint/node_modules/file-entry-cache/ cache.js:2:14) at Module._compile (internal/modules/cjs/loader.js:746:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:757:10) make: *** [lint-js] Error 1 There are also a number of tests that are affected in a similar way. This commit adds crypto checks to allow for lint-js and the affected tests to be skipped when configured --without-ssl. PR-URL: https://github.com/nodejs/node/pull/26182 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2019-02-02tools: improve prerequisites for test-all-suitesRich Trott
The prerequisistes for test-all-suites were running some tests themselves. When one of those tests failed during a coverage run, it resulted in artificially low coverage. Fix the prerequisites to only build stuff, not test. PR-URL: https://github.com/nodejs/node/pull/25892 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
2019-02-01tools: exclude benchmark code from coverage reportRich Trott
Refs: https://github.com/nodejs/build/issues/1676#issuecomment-459218651 PR-URL: https://github.com/nodejs/node/pull/25841 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
2019-02-01tools: add test-all-suites to MakefileRich Trott
There is currently no Makefile target that runs every test suite. This adds one. PR-URL: https://github.com/nodejs/node/pull/25799 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
2019-02-01test: allow coverage threshold to be enforcedBenjamin Coe
If COV_ENFORCE_THRESHOLD is set, tests run in coverage mode will exit with an error, if line coverage is below the percentage threshold. PR-URL: https://github.com/nodejs/node/pull/25675 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
2019-01-29test: enable marking of failing coverage testsMichael Dawson
Enable marking of coverage tests so that we can allow some tests to fail without blocking the generation of coverage data. This will later allow us to fail the coverage job if other kinds of errors occur and to capture which tests we believe are not running properly with coverage enabled. PR-URL: https://github.com/nodejs/node/pull/25671 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
2019-01-22build: do not lint python scripts under test/fixturesJoyee Cheung
PR-URL: https://github.com/nodejs/node/pull/25639 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
2019-01-20test: switch to native v8 coverageBenjamin Coe
PR-URL: https://github.com/nodejs/node/pull/25157 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
2019-01-17test: revert fail `coverage` target if tests fail"Michael Dawson
This reverts commit f216d5bbb1595f2fbed29517ba87b80e8c02f3c0. Seems like it breaks the nightly job so reverting until we figure that out. PR-URL: https://github.com/nodejs/node/pull/25543 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2019-01-15build,test: fail `coverage` target if tests failRefael Ackermann
PR-URL: https://github.com/nodejs/node/pull/25432 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
2018-12-21tools: report unused disable-directives for ESLintRich Trott
Refs: https://eslint.org/docs/user-guide/command-line-interface#--report-unused-disable-directives PR-URL: https://github.com/nodejs/node/pull/25119 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
2018-12-21build: correct fi indentation in MakefileDaniel Bevenius
PR-URL: https://github.com/nodejs/node/pull/25107 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2018-12-18tools: make apilinks building more robustJoyee Cheung
1. Move the apilinks.json file into out/doc so it gets cleaned when running `make docclean` 2. When the apilinks.json generated is empty, throw a specific error so it's easier to understand what's wrong 3. Write to a file passed through CLI arguments instead writing to stdout in apilinks.js so the build process is more robust in the case of a bad binary PR-URL: https://github.com/nodejs/node/pull/25019 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
2018-12-15build: make lint-addon-docs run only if neededDaniel Bevenius
Currently, the lint-addon-docs targets recipe will always be run. This commit makes lint-addon-docs a phony target and adds a new target named tools/.doclintstamp what will be an actual file, similar to what the lint-cpp target does. PR-URL: https://github.com/nodejs/node/pull/24993 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
2018-12-09tools: do not lint tools/inspector_protocol or tools/markupsafecclauss
PR-URL: https://github.com/nodejs/node/pull/24882 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2018-12-05build: add '.git' to 'make lint-py' exclude listcclauss
When run locally [flake8](http://flake8.pycqa.org) was creating false positives by scanning the __.git__ directory. This PR prevents that behavior. PR-URL: https://github.com/nodejs/node/pull/24802 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2018-12-04build: fix check-xz for platforms defaulting to shRod Vagg
5e80a9a160 introduced check-xz, using `[[ .. ]]` syntax, but this is a bash builtin and some platforms default to `sh` when doing `$(shell ...)` in Makefiles. Fix is to make it sh friendly. Ref: https://github.com/nodejs/node/pull/24551 PR-URL: https://github.com/nodejs/node/pull/24841 Refs: https://github.com/nodejs/node/pull/24551 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 12:05:29 +0000