diff options
| author | Rich Trott <rtrott@gmail.com> | 2019-02-02 06:07:00 -0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-02-02 17:20:20 -0800 |
| commit | 4deb23a2f66e576be96c3bb856e5199cb3439865 (patch) | |
| tree | d8da29d893788da3b785cd271fca2cb7b6de92c6 /Makefile | |
| parent | fba96ca1fd1ca0d3b95ade44ebf83c26a4e39696 (diff) | |
| download | android-node-v8-4deb23a2f66e576be96c3bb856e5199cb3439865.tar.gz android-node-v8-4deb23a2f66e576be96c3bb856e5199cb3439865.tar.bz2 android-node-v8-4deb23a2f66e576be96c3bb856e5199cb3439865.zip | |
tools: improve prerequisites for test-all-suites
The prerequisistes for test-all-suites were running some tests
themselves. When one of those tests failed during a coverage run, it
resulted in artificially low coverage. Fix the prerequisites to only
build stuff, not test.
PR-URL: https://github.com/nodejs/node/pull/25892
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'Makefile')
| -rw-r--r-- | Makefile | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -467,7 +467,7 @@ test-all-valgrind: test-build $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=debug,release --valgrind .PHONY: test-all-suites -test-all-suites: test-build test-js-native-api test-node-api | bench-addons-build ## Run all test suites. +test-all-suites: | clear-stalled test-build bench-addons-build doc-only ## Run all test suites. $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) test/* CI_NATIVE_SUITES ?= addons js-native-api node-api |