summaryrefslogtreecommitdiff
path: root/tools/eslint-rules
diff options
context:
space:
mode:
Diffstat (limited to 'tools/eslint-rules')
-rw-r--r--tools/eslint-rules/crypto-check.js7
-rw-r--r--tools/eslint-rules/rules-utils.js12
2 files changed, 18 insertions, 1 deletions
diff --git a/tools/eslint-rules/crypto-check.js b/tools/eslint-rules/crypto-check.js
index 9d24d3355d..9570c24c03 100644
--- a/tools/eslint-rules/crypto-check.js
+++ b/tools/eslint-rules/crypto-check.js
@@ -16,13 +16,18 @@ const utils = require('./rules-utils.js');
const msg = 'Please add a hasCrypto check to allow this test to be skipped ' +
'when Node is built "--without-ssl".';
+const cryptoModules = ['crypto', 'http2'];
+const requireModules = cryptoModules.concat(['tls', 'https']);
+const bindingModules = cryptoModules.concat(['tls_wrap']);
+
module.exports = function(context) {
const missingCheckNodes = [];
const requireNodes = [];
var hasSkipCall = false;
function testCryptoUsage(node) {
- if (utils.isRequired(node, ['crypto', 'tls', 'https', 'http2'])) {
+ if (utils.isRequired(node, requireModules) ||
+ utils.isBinding(node, bindingModules)) {
requireNodes.push(node);
}
}
diff --git a/tools/eslint-rules/rules-utils.js b/tools/eslint-rules/rules-utils.js
index f2f5428ed1..2bfab1c639 100644
--- a/tools/eslint-rules/rules-utils.js
+++ b/tools/eslint-rules/rules-utils.js
@@ -13,6 +13,18 @@ module.exports.isRequired = function(node, modules) {
};
/**
+ * Returns true if any of the passed in modules are used in
+ * binding calls.
+ */
+module.exports.isBinding = function(node, modules) {
+ if (node.callee.object) {
+ return node.callee.object.name === 'process' &&
+ node.callee.property.name === 'binding' &&
+ modules.includes(node.arguments[0].value);
+ }
+};
+
+/**
* Returns true is the node accesses any property in the properties
* array on the 'common' object.
*/