summaryrefslogtreecommitdiff
path: root/lib/domain.js
diff options
context:
space:
mode:
Diffstat (limited to 'lib/domain.js')
-rw-r--r--lib/domain.js13
1 files changed, 10 insertions, 3 deletions
diff --git a/lib/domain.js b/lib/domain.js
index 8d96683312..031350746c 100644
--- a/lib/domain.js
+++ b/lib/domain.js
@@ -35,6 +35,10 @@ const {
} = require('internal/errors').codes;
const { createHook } = require('async_hooks');
+// TODO(addaleax): Use a non-internal solution for this.
+const kWeak = Symbol('kWeak');
+const { WeakReference } = internalBinding('util');
+
// Overwrite process.domain with a getter/setter that will allow for more
// effective optimizations
var _domain = [null];
@@ -53,20 +57,22 @@ const asyncHook = createHook({
init(asyncId, type, triggerAsyncId, resource) {
if (process.domain !== null && process.domain !== undefined) {
// If this operation is created while in a domain, let's mark it
- pairing.set(asyncId, process.domain);
+ pairing.set(asyncId, process.domain[kWeak]);
resource.domain = process.domain;
}
},
before(asyncId) {
const current = pairing.get(asyncId);
if (current !== undefined) { // enter domain for this cb
- current.enter();
+ // We will get the domain through current.get(), because the resource
+ // object's .domain property makes sure it is not garbage collected.
+ current.get().enter();
}
},
after(asyncId) {
const current = pairing.get(asyncId);
if (current !== undefined) { // exit domain for this cb
- current.exit();
+ current.get().exit();
}
},
destroy(asyncId) {
@@ -167,6 +173,7 @@ class Domain extends EventEmitter {
super();
this.members = [];
+ this[kWeak] = new WeakReference(this);
asyncHook.enable();
this.on('removeListener', updateExceptionCapture);