summaryrefslogtreecommitdiff
path: root/deps/v8/test/unittests/compiler/js-type-feedback-unittest.cc
diff options
context:
space:
mode:
Diffstat (limited to 'deps/v8/test/unittests/compiler/js-type-feedback-unittest.cc')
-rw-r--r--deps/v8/test/unittests/compiler/js-type-feedback-unittest.cc29
1 files changed, 10 insertions, 19 deletions
diff --git a/deps/v8/test/unittests/compiler/js-type-feedback-unittest.cc b/deps/v8/test/unittests/compiler/js-type-feedback-unittest.cc
index 251293ddcf..f3f1b733fc 100644
--- a/deps/v8/test/unittests/compiler/js-type-feedback-unittest.cc
+++ b/deps/v8/test/unittests/compiler/js-type-feedback-unittest.cc
@@ -82,18 +82,11 @@ class JSTypeFeedbackTest : public TypedGraphTest {
Node* vector = UndefinedConstant();
Node* context = UndefinedConstant();
- Unique<Name> name = Unique<Name>::CreateUninitialized(
- isolate()->factory()->InternalizeUtf8String(string));
+ Handle<Name> name = isolate()->factory()->InternalizeUtf8String(string);
const Operator* op = javascript()->LoadGlobal(name, feedback);
- Node* load = graph()->NewNode(op, context, global, vector, context);
- if (mode == JSTypeFeedbackSpecializer::kDeoptimizationEnabled) {
- for (int i = 0; i < OperatorProperties::GetFrameStateInputCount(op);
- i++) {
- load->AppendInput(zone(), EmptyFrameState());
- }
- }
- load->AppendInput(zone(), effect);
- load->AppendInput(zone(), control);
+ Node* load =
+ graph()->NewNode(op, context, global, vector, context,
+ EmptyFrameState(), EmptyFrameState(), effect, control);
Node* if_success = graph()->NewNode(common()->IfSuccess(), load);
return graph()->NewNode(common()->Return(), load, load, if_success);
}
@@ -193,10 +186,9 @@ TEST_F(JSTypeFeedbackTest, JSLoadNamedGlobalConstNumberWithDeoptimization) {
TEST_F(JSTypeFeedbackTest, JSLoadNamedGlobalConstString) {
- Unique<HeapObject> kValue = Unique<HeapObject>::CreateImmovable(
- isolate()->factory()->undefined_string());
+ Handle<HeapObject> kValue = isolate()->factory()->undefined_string();
const char* kName = "mango";
- SetGlobalProperty(kName, kValue.handle());
+ SetGlobalProperty(kName, kValue);
Node* ret = ReturnLoadNamedFromGlobal(
kName, graph()->start(), graph()->start(),
@@ -211,10 +203,9 @@ TEST_F(JSTypeFeedbackTest, JSLoadNamedGlobalConstString) {
TEST_F(JSTypeFeedbackTest, JSLoadNamedGlobalConstStringWithDeoptimization) {
- Unique<HeapObject> kValue = Unique<HeapObject>::CreateImmovable(
- isolate()->factory()->undefined_string());
+ Handle<HeapObject> kValue = isolate()->factory()->undefined_string();
const char* kName = "mango";
- SetGlobalProperty(kName, kValue.handle());
+ SetGlobalProperty(kName, kValue);
Node* ret = ReturnLoadNamedFromGlobal(
kName, graph()->start(), graph()->start(),
@@ -277,7 +268,7 @@ TEST_F(JSTypeFeedbackTest, JSLoadNamedGlobalPropertyCellSmiWithDeoptimization) {
HeapObjectMatcher cell(cell_capture.value());
EXPECT_TRUE(cell.HasValue());
- EXPECT_TRUE(cell.Value().handle()->IsPropertyCell());
+ EXPECT_TRUE(cell.Value()->IsPropertyCell());
EXPECT_THAT(ret,
IsReturn(load_field_match, load_field_match, graph()->start()));
@@ -329,7 +320,7 @@ TEST_F(JSTypeFeedbackTest,
HeapObjectMatcher cell(cell_capture.value());
EXPECT_TRUE(cell.HasValue());
- EXPECT_TRUE(cell.Value().handle()->IsPropertyCell());
+ EXPECT_TRUE(cell.Value()->IsPropertyCell());
EXPECT_THAT(ret,
IsReturn(load_field_match, load_field_match, graph()->start()));