diff options
Diffstat (limited to 'deps/v8/test/cctest/test-field-type-tracking.cc')
-rw-r--r-- | deps/v8/test/cctest/test-field-type-tracking.cc | 22 |
1 files changed, 12 insertions, 10 deletions
diff --git a/deps/v8/test/cctest/test-field-type-tracking.cc b/deps/v8/test/cctest/test-field-type-tracking.cc index 89845e9bf5..9622da53b8 100644 --- a/deps/v8/test/cctest/test-field-type-tracking.cc +++ b/deps/v8/test/cctest/test-field-type-tracking.cc @@ -66,11 +66,11 @@ static Handle<AccessorPair> CreateAccessorPair(bool with_getter, Handle<AccessorPair> pair = factory->NewAccessorPair(); Handle<String> empty_string = factory->empty_string(); if (with_getter) { - Handle<JSFunction> func = factory->NewFunction(empty_string); + Handle<JSFunction> func = factory->NewFunctionForTest(empty_string); pair->set_getter(*func); } if (with_setter) { - Handle<JSFunction> func = factory->NewFunction(empty_string); + Handle<JSFunction> func = factory->NewFunctionForTest(empty_string); pair->set_setter(*func); } return pair; @@ -401,7 +401,7 @@ class Expectations { Handle<String> name = MakeName("prop", property_index); Map* target = TransitionsAccessor(map).SearchTransition(*name, kData, attributes); - CHECK(target != NULL); + CHECK_NOT_NULL(target); return handle(target); } @@ -609,7 +609,7 @@ static void TestGeneralizeField(int detach_property_at_index, CHECK(detach_property_at_index >= -1 && detach_property_at_index < kPropCount); - CHECK(property_index < kPropCount); + CHECK_LT(property_index, kPropCount); CHECK_NE(detach_property_at_index, property_index); const bool is_detached_map = detach_property_at_index >= 0; @@ -1405,7 +1405,7 @@ static void TestReconfigureProperty_CustomPropertyAfterTargetMap( Expectations expectations(isolate); const int kSplitProp = 2; - CHECK(kSplitProp < kCustomPropIndex); + CHECK_LT(kSplitProp, kCustomPropIndex); const PropertyConstness constness = kMutable; const Representation representation = Representation::Smi(); @@ -1484,7 +1484,7 @@ TEST(ReconfigureDataFieldAttribute_SameDataConstantAfterTargetMap) { TestConfig() { Isolate* isolate = CcTest::i_isolate(); Factory* factory = isolate->factory(); - js_func_ = factory->NewFunction(factory->empty_string()); + js_func_ = factory->NewFunctionForTest(factory->empty_string()); } Handle<Map> AddPropertyAtBranch(int branch_id, Expectations& expectations, @@ -1570,7 +1570,7 @@ TEST(ReconfigureDataFieldAttribute_DataConstantToAccConstantAfterTargetMap) { TestConfig() { Isolate* isolate = CcTest::i_isolate(); Factory* factory = isolate->factory(); - js_func_ = factory->NewFunction(factory->empty_string()); + js_func_ = factory->NewFunctionForTest(factory->empty_string()); pair_ = CreateAccessorPair(true, true); } @@ -2121,7 +2121,7 @@ TEST(ReconfigurePropertySplitMapTransitionsOverflow) { Handle<String> name = MakeName("prop", i); Map* target = TransitionsAccessor(map2).SearchTransition(*name, kData, NONE); - CHECK(target != NULL); + CHECK_NOT_NULL(target); map2 = handle(target); } @@ -2643,7 +2643,8 @@ TEST(TransitionDataConstantToSameDataConstant) { Isolate* isolate = CcTest::i_isolate(); Factory* factory = isolate->factory(); - Handle<JSFunction> js_func = factory->NewFunction(factory->empty_string()); + Handle<JSFunction> js_func = + factory->NewFunctionForTest(factory->empty_string()); TransitionToDataConstantOperator transition_op(js_func); SameMapChecker checker; @@ -2690,7 +2691,8 @@ TEST(TransitionDataConstantToDataField) { Factory* factory = isolate->factory(); Handle<FieldType> any_type = FieldType::Any(isolate); - Handle<JSFunction> js_func1 = factory->NewFunction(factory->empty_string()); + Handle<JSFunction> js_func1 = + factory->NewFunctionForTest(factory->empty_string()); TransitionToDataConstantOperator transition_op1(js_func1); Handle<Object> value2 = isolate->factory()->NewHeapNumber(0); |