diff options
Diffstat (limited to 'deps/v8/src/libplatform')
9 files changed, 10 insertions, 13 deletions
diff --git a/deps/v8/src/libplatform/default-platform.cc b/deps/v8/src/libplatform/default-platform.cc index 3c29bd7eaa..c23616116e 100644 --- a/deps/v8/src/libplatform/default-platform.cc +++ b/deps/v8/src/libplatform/default-platform.cc @@ -140,11 +140,9 @@ bool DefaultPlatform::PumpMessageLoop(v8::Isolate* isolate, std::shared_ptr<DefaultForegroundTaskRunner> task_runner; { base::LockGuard<base::Mutex> guard(&lock_); - if (foreground_task_runner_map_.find(isolate) == - foreground_task_runner_map_.end()) { - return failed_result; - } - task_runner = foreground_task_runner_map_[isolate]; + auto it = foreground_task_runner_map_.find(isolate); + if (it == foreground_task_runner_map_.end()) return failed_result; + task_runner = it->second; } std::unique_ptr<Task> task = task_runner->PopTaskFromQueue(wait_for_work); diff --git a/deps/v8/src/libplatform/default-platform.h b/deps/v8/src/libplatform/default-platform.h index 1c844f0f09..40a945fd8a 100644 --- a/deps/v8/src/libplatform/default-platform.h +++ b/deps/v8/src/libplatform/default-platform.h @@ -35,7 +35,7 @@ class V8_PLATFORM_EXPORT DefaultPlatform : public NON_EXPORTED_BASE(Platform) { IdleTaskSupport idle_task_support = IdleTaskSupport::kDisabled, std::unique_ptr<v8::TracingController> tracing_controller = {}); - virtual ~DefaultPlatform(); + ~DefaultPlatform() override; void SetThreadPoolSize(int thread_pool_size); diff --git a/deps/v8/src/libplatform/default-worker-threads-task-runner.cc b/deps/v8/src/libplatform/default-worker-threads-task-runner.cc index 4251d8076e..f3338acfe3 100644 --- a/deps/v8/src/libplatform/default-worker-threads-task-runner.cc +++ b/deps/v8/src/libplatform/default-worker-threads-task-runner.cc @@ -17,6 +17,7 @@ DefaultWorkerThreadsTaskRunner::DefaultWorkerThreadsTaskRunner( } } +// NOLINTNEXTLINE DefaultWorkerThreadsTaskRunner::~DefaultWorkerThreadsTaskRunner() { // This destructor is needed because we have unique_ptr to the WorkerThreads, // und the {WorkerThread} class is forward declared in the header file. diff --git a/deps/v8/src/libplatform/default-worker-threads-task-runner.h b/deps/v8/src/libplatform/default-worker-threads-task-runner.h index 5e46e3dd41..0b146a509c 100644 --- a/deps/v8/src/libplatform/default-worker-threads-task-runner.h +++ b/deps/v8/src/libplatform/default-worker-threads-task-runner.h @@ -19,7 +19,7 @@ class V8_PLATFORM_EXPORT DefaultWorkerThreadsTaskRunner public: DefaultWorkerThreadsTaskRunner(uint32_t thread_pool_size); - ~DefaultWorkerThreadsTaskRunner(); + ~DefaultWorkerThreadsTaskRunner() override; void Terminate(); diff --git a/deps/v8/src/libplatform/tracing/trace-buffer.cc b/deps/v8/src/libplatform/tracing/trace-buffer.cc index c7142ea520..8bec153440 100644 --- a/deps/v8/src/libplatform/tracing/trace-buffer.cc +++ b/deps/v8/src/libplatform/tracing/trace-buffer.cc @@ -15,8 +15,6 @@ TraceBufferRingBuffer::TraceBufferRingBuffer(size_t max_chunks, chunks_.resize(max_chunks); } -TraceBufferRingBuffer::~TraceBufferRingBuffer() {} - TraceObject* TraceBufferRingBuffer::AddTraceEvent(uint64_t* handle) { base::LockGuard<base::Mutex> guard(&mutex_); if (is_empty_ || chunks_[chunk_index_]->IsFull()) { diff --git a/deps/v8/src/libplatform/tracing/trace-buffer.h b/deps/v8/src/libplatform/tracing/trace-buffer.h index 3c756b7a69..95b9313338 100644 --- a/deps/v8/src/libplatform/tracing/trace-buffer.h +++ b/deps/v8/src/libplatform/tracing/trace-buffer.h @@ -18,7 +18,7 @@ namespace tracing { class TraceBufferRingBuffer : public TraceBuffer { public: TraceBufferRingBuffer(size_t max_chunks, TraceWriter* trace_writer); - ~TraceBufferRingBuffer(); + ~TraceBufferRingBuffer() override = default; TraceObject* AddTraceEvent(uint64_t* handle) override; TraceObject* GetEventByHandle(uint64_t handle) override; diff --git a/deps/v8/src/libplatform/tracing/trace-writer.h b/deps/v8/src/libplatform/tracing/trace-writer.h index d811351389..df48c5a377 100644 --- a/deps/v8/src/libplatform/tracing/trace-writer.h +++ b/deps/v8/src/libplatform/tracing/trace-writer.h @@ -15,7 +15,7 @@ class JSONTraceWriter : public TraceWriter { public: explicit JSONTraceWriter(std::ostream& stream); JSONTraceWriter(std::ostream& stream, const std::string& tag); - ~JSONTraceWriter(); + ~JSONTraceWriter() override; void AppendTraceEvent(TraceObject* trace_event) override; void Flush() override; diff --git a/deps/v8/src/libplatform/tracing/tracing-controller.cc b/deps/v8/src/libplatform/tracing/tracing-controller.cc index aa8789fa07..3d02347216 100644 --- a/deps/v8/src/libplatform/tracing/tracing-controller.cc +++ b/deps/v8/src/libplatform/tracing/tracing-controller.cc @@ -40,7 +40,7 @@ const int g_num_builtin_categories = 3; // Skip default categories. v8::base::AtomicWord g_category_index = g_num_builtin_categories; -TracingController::TracingController() {} +TracingController::TracingController() = default; TracingController::~TracingController() { StopTracing(); diff --git a/deps/v8/src/libplatform/worker-thread.h b/deps/v8/src/libplatform/worker-thread.h index 22b0626024..abf0383e03 100644 --- a/deps/v8/src/libplatform/worker-thread.h +++ b/deps/v8/src/libplatform/worker-thread.h @@ -21,7 +21,7 @@ class TaskQueue; class V8_PLATFORM_EXPORT WorkerThread : public NON_EXPORTED_BASE(base::Thread) { public: explicit WorkerThread(TaskQueue* queue); - virtual ~WorkerThread(); + ~WorkerThread() override; // Thread implementation. void Run() override; |