diff options
Diffstat (limited to 'deps/v8/src/inspector/v8-inspector-impl.cc')
-rw-r--r-- | deps/v8/src/inspector/v8-inspector-impl.cc | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/deps/v8/src/inspector/v8-inspector-impl.cc b/deps/v8/src/inspector/v8-inspector-impl.cc index 62790a6335..5422b5e12f 100644 --- a/deps/v8/src/inspector/v8-inspector-impl.cc +++ b/deps/v8/src/inspector/v8-inspector-impl.cc @@ -359,7 +359,8 @@ V8Console* V8InspectorImpl::console() { } void V8InspectorImpl::forEachContext( - int contextGroupId, std::function<void(InspectedContext*)> callback) { + int contextGroupId, + const std::function<void(InspectedContext*)>& callback) { auto it = m_contexts.find(contextGroupId); if (it == m_contexts.end()) return; std::vector<int> ids; @@ -376,7 +377,8 @@ void V8InspectorImpl::forEachContext( } void V8InspectorImpl::forEachSession( - int contextGroupId, std::function<void(V8InspectorSessionImpl*)> callback) { + int contextGroupId, + const std::function<void(V8InspectorSessionImpl*)>& callback) { auto it = m_sessions.find(contextGroupId); if (it == m_sessions.end()) return; std::vector<int> ids; @@ -411,9 +413,9 @@ V8InspectorImpl::EvaluateScope::~EvaluateScope() { class V8InspectorImpl::EvaluateScope::TerminateTask : public v8::Task { public: TerminateTask(v8::Isolate* isolate, std::shared_ptr<CancelToken> token) - : m_isolate(isolate), m_token(token) {} + : m_isolate(isolate), m_token(std::move(token)) {} - void Run() { + void Run() override { // CancelToken contains m_canceled bool which may be changed from main // thread, so lock mutex first. v8::base::LockGuard<v8::base::Mutex> lock(&m_token->m_mutex); |