summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--doc/api/http2.md8
-rw-r--r--lib/internal/http2/compat.js8
-rw-r--r--lib/internal/http2/core.js10
-rw-r--r--test/parallel/test-http2-options-server-request.js40
-rw-r--r--test/parallel/test-http2-options-server-response.js34
5 files changed, 95 insertions, 5 deletions
diff --git a/doc/api/http2.md b/doc/api/http2.md
index 083a491cca..8b428484c0 100644
--- a/doc/api/http2.md
+++ b/doc/api/http2.md
@@ -1707,6 +1707,14 @@ changes:
* `Http1ServerResponse` {http.ServerResponse} Specifies the ServerResponse
class to used for HTTP/1 fallback. Useful for extending the original
`http.ServerResponse`. **Default:** `http.ServerResponse`
+ * `Http2ServerRequest` {http2.Http2ServerRequest} Specifies the
+ Http2ServerRequest class to use.
+ Useful for extending the original `Http2ServerRequest`.
+ **Default:** `Http2ServerRequest`
+ * `Http2ServerResponse` {htt2.Http2ServerResponse} Specifies the
+ Http2ServerResponse class to use.
+ Useful for extending the original `Http2ServerResponse`.
+ **Default:** `Http2ServerResponse`
* `onRequestHandler` {Function} See [Compatibility API][]
* Returns: {Http2Server}
diff --git a/lib/internal/http2/compat.js b/lib/internal/http2/compat.js
index b5dd81c80f..5e6c51377e 100644
--- a/lib/internal/http2/compat.js
+++ b/lib/internal/http2/compat.js
@@ -661,11 +661,11 @@ class Http2ServerResponse extends Stream {
}
}
-function onServerStream(stream, headers, flags, rawHeaders) {
+function onServerStream(ServerRequest, ServerResponse,
+ stream, headers, flags, rawHeaders) {
const server = this;
- const request = new Http2ServerRequest(stream, headers, undefined,
- rawHeaders);
- const response = new Http2ServerResponse(stream);
+ const request = new ServerRequest(stream, headers, undefined, rawHeaders);
+ const response = new ServerResponse(stream);
// Check for the CONNECT method
const method = headers[HTTP2_HEADER_METHOD];
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
index 5f811ca8af..307ca98db8 100644
--- a/lib/internal/http2/core.js
+++ b/lib/internal/http2/core.js
@@ -2498,6 +2498,10 @@ function initializeOptions(options) {
options.Http1ServerResponse = options.Http1ServerResponse ||
http.ServerResponse;
+ options.Http2ServerRequest = options.Http2ServerRequest ||
+ Http2ServerRequest;
+ options.Http2ServerResponse = options.Http2ServerResponse ||
+ Http2ServerResponse;
return options;
}
@@ -2563,7 +2567,11 @@ class Http2Server extends NETServer {
function setupCompat(ev) {
if (ev === 'request') {
this.removeListener('newListener', setupCompat);
- this.on('stream', onServerStream);
+ this.on('stream', onServerStream.bind(
+ this,
+ this[kOptions].Http2ServerRequest,
+ this[kOptions].Http2ServerResponse)
+ );
}
}
diff --git a/test/parallel/test-http2-options-server-request.js b/test/parallel/test-http2-options-server-request.js
new file mode 100644
index 0000000000..2143d37982
--- /dev/null
+++ b/test/parallel/test-http2-options-server-request.js
@@ -0,0 +1,40 @@
+'use strict';
+
+const common = require('../common');
+if (!common.hasCrypto)
+ common.skip('missing crypto');
+const assert = require('assert');
+const h2 = require('http2');
+
+class MyServerRequest extends h2.Http2ServerRequest {
+ getUserAgent() {
+ return this.headers['user-agent'] || 'unknown';
+ }
+}
+
+const server = h2.createServer({
+ Http2ServerRequest: MyServerRequest
+}, (req, res) => {
+ assert.strictEqual(req.getUserAgent(), 'node-test');
+
+ res.writeHead(200, { 'Content-Type': 'text/plain' });
+ res.end();
+});
+server.listen(0);
+
+server.on('listening', common.mustCall(() => {
+
+ const client = h2.connect(`http://localhost:${server.address().port}`);
+ const req = client.request({
+ ':path': '/',
+ 'User-Agent': 'node-test'
+ });
+
+ req.on('response', common.mustCall());
+
+ req.resume();
+ req.on('end', common.mustCall(() => {
+ server.close();
+ client.destroy();
+ }));
+}));
diff --git a/test/parallel/test-http2-options-server-response.js b/test/parallel/test-http2-options-server-response.js
new file mode 100644
index 0000000000..6f1ae1881d
--- /dev/null
+++ b/test/parallel/test-http2-options-server-response.js
@@ -0,0 +1,34 @@
+'use strict';
+
+const common = require('../common');
+if (!common.hasCrypto)
+ common.skip('missing crypto');
+const h2 = require('http2');
+
+class MyServerResponse extends h2.Http2ServerResponse {
+ status(code) {
+ return this.writeHead(code, { 'Content-Type': 'text/plain' });
+ }
+}
+
+const server = h2.createServer({
+ Http2ServerResponse: MyServerResponse
+}, (req, res) => {
+ res.status(200);
+ res.end();
+});
+server.listen(0);
+
+server.on('listening', common.mustCall(() => {
+
+ const client = h2.connect(`http://localhost:${server.address().port}`);
+ const req = client.request({ ':path': '/' });
+
+ req.on('response', common.mustCall());
+
+ req.resume();
+ req.on('end', common.mustCall(() => {
+ server.close();
+ client.destroy();
+ }));
+}));