summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--lib/_tls_legacy.js7
-rw-r--r--lib/_tls_wrap.js7
-rw-r--r--test/simple/test-tls-ocsp-callback.js28
3 files changed, 31 insertions, 11 deletions
diff --git a/lib/_tls_legacy.js b/lib/_tls_legacy.js
index 5e501be9a6..3f6d20784b 100644
--- a/lib/_tls_legacy.js
+++ b/lib/_tls_legacy.js
@@ -655,14 +655,17 @@ function onnewsession(key, session) {
var self = this;
var once = false;
- self.server.emit('newSession', key, session, function() {
+ if (!self.server.emit('newSession', key, session, done))
+ done();
+
+ function done() {
if (once)
return;
once = true;
if (self.ssl)
self.ssl.newSessionDone();
- });
+ };
}
diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
index 4ec92801b1..703f125839 100644
--- a/lib/_tls_wrap.js
+++ b/lib/_tls_wrap.js
@@ -200,7 +200,10 @@ function onnewsession(key, session) {
var once = false;
this._newSessionPending = true;
- this.server.emit('newSession', key, session, function() {
+ if (!this.server.emit('newSession', key, session, done))
+ done();
+
+ function done() {
if (once)
return;
once = true;
@@ -211,7 +214,7 @@ function onnewsession(key, session) {
if (self._securePending)
self._finishInit();
self._securePending = false;
- });
+ }
}
diff --git a/test/simple/test-tls-ocsp-callback.js b/test/simple/test-tls-ocsp-callback.js
index fd45586b5e..4c7dd1d442 100644
--- a/test/simple/test-tls-ocsp-callback.js
+++ b/test/simple/test-tls-ocsp-callback.js
@@ -31,16 +31,19 @@ if (!common.opensslCli) {
process.exit(0);
}
+var assert = require('assert');
+var tls = require('tls');
+var constants = require('constants');
+var fs = require('fs');
+var join = require('path').join;
+
test({ response: false }, function() {
- test({ response: 'hello world' });
+ test({ response: 'hello world' }, function() {
+ test({ ocsp: false });
+ });
});
function test(testOptions, cb) {
- var assert = require('assert');
- var tls = require('tls');
- var fs = require('fs');
- var join = require('path').join;
- var spawn = require('child_process').spawn;
var keyFile = join(common.fixturesDir, 'keys', 'agent1-key.pem');
var certFile = join(common.fixturesDir, 'keys', 'agent1-cert.pem');
@@ -54,6 +57,7 @@ function test(testOptions, cb) {
ca: [ca]
};
var requestCount = 0;
+ var clientSecure = 0;
var ocspCount = 0;
var ocspResponse;
var session;
@@ -83,9 +87,12 @@ function test(testOptions, cb) {
server.listen(common.PORT, function() {
var client = tls.connect({
port: common.PORT,
- requestOCSP: true,
+ requestOCSP: testOptions.ocsp !== false,
+ secureOptions: testOptions.ocsp === false ?
+ constants.SSL_OP_NO_TICKET : 0,
rejectUnauthorized: false
}, function() {
+ clientSecure++;
});
client.on('OCSPResponse', function(resp) {
ocspResponse = resp;
@@ -98,12 +105,19 @@ function test(testOptions, cb) {
});
process.on('exit', function() {
+ if (testOptions.ocsp === false) {
+ assert.equal(requestCount, clientSecure);
+ assert.equal(requestCount, 1);
+ return;
+ }
+
if (testOptions.response) {
assert.equal(ocspResponse.toString(), testOptions.response);
} else {
assert.ok(ocspResponse === null);
}
assert.equal(requestCount, testOptions.response ? 0 : 1);
+ assert.equal(clientSecure, requestCount);
assert.equal(ocspCount, 1);
});
}