diff options
| -rw-r--r-- | lib/fs.js | 6 | ||||
| -rw-r--r-- | test/parallel/test-fs-read-stream-throw-type-error.js | 8 |
2 files changed, 12 insertions, 2 deletions
@@ -2009,12 +2009,12 @@ function ReadStream(path, options) { this.closed = false; if (this.start !== undefined) { - if (typeof this.start !== 'number') { + if (typeof this.start !== 'number' || Number.isNaN(this.start)) { throw new ERR_INVALID_ARG_TYPE('start', 'number', this.start); } if (this.end === undefined) { this.end = Infinity; - } else if (typeof this.end !== 'number') { + } else if (typeof this.end !== 'number' || Number.isNaN(this.end)) { throw new ERR_INVALID_ARG_TYPE('end', 'number', this.end); } @@ -2031,6 +2031,8 @@ function ReadStream(path, options) { // (That is a semver-major change). if (typeof this.end !== 'number') this.end = Infinity; + else if (Number.isNaN(this.end)) + throw new ERR_INVALID_ARG_TYPE('end', 'number', this.end); if (typeof this.fd !== 'number') this.open(); diff --git a/test/parallel/test-fs-read-stream-throw-type-error.js b/test/parallel/test-fs-read-stream-throw-type-error.js index c2b0d5452c..5cba76fa39 100644 --- a/test/parallel/test-fs-read-stream-throw-type-error.js +++ b/test/parallel/test-fs-read-stream-throw-type-error.js @@ -3,6 +3,9 @@ const common = require('../common'); const fixtures = require('../common/fixtures'); const fs = require('fs'); +// This test ensures that appropriate TypeError is thrown by createReadStream +// when an argument with invalid type is passed + const example = fixtures.path('x.txt'); // Should not throw. fs.createReadStream(example, undefined); @@ -25,3 +28,8 @@ createReadStreamErr(example, 123); createReadStreamErr(example, 0); createReadStreamErr(example, true); createReadStreamErr(example, false); + +// createReadSteam _should_ throw on NaN +createReadStreamErr(example, { start: NaN }); +createReadStreamErr(example, { end: NaN }); +createReadStreamErr(example, { start: NaN, end: NaN }); |