diff options
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 8 | ||||
| -rw-r--r-- | doc/onboarding.md | 5 |
2 files changed, 6 insertions, 7 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 513faa46c8..75b3c5e6c2 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -171,10 +171,10 @@ agenda. ### Waiting for Approvals Before landing pull requests, sufficient time should be left for input -from other Collaborators. In general, leave at least 48 hours during the -week and 72 hours over weekends to account for international time -differences and work schedules. However, certain types of pull requests -can be fast-tracked and may be landed after a shorter delay. For example: +from other Collaborators. In general, leave at least 72 hours to account for +international time differences and work schedules. However, certain types of +pull requests can be fast-tracked and may be landed after a shorter delay. For +example: * Focused changes that affect only documentation and/or the test suite: * `code-and-learn` tasks typically fall into this category. diff --git a/doc/onboarding.md b/doc/onboarding.md index 3a03edb17e..bd9418fd91 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -138,8 +138,7 @@ onboarding session. * There is a minimum waiting time which we try to respect for non-trivial changes so that people who may have important input in such a distributed project are able to respond. - * For non-trivial changes, leave the pull request open for at least 48 hours - (72 hours on a weekend). + * For non-trivial changes, leave the pull request open for at least 72 hours. * If a pull request is abandoned, check if they'd mind if you took it over (especially if it just has nits left). * Approving a change @@ -215,7 +214,7 @@ needs to be pointed out separately during the onboarding. * Run CI on the PR. Because the PR does not affect any code, use the `node-test-pull-request-lite-pipeline` CI task. * After one or two approvals, land the PR (PRs of this type do not need to wait - for 48/72 hours to land). + for 72 hours to land). * Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:` metadata. * [`node-core-utils`][] automates the generation of metadata and the landing |