diff options
| -rw-r--r-- | src/env.cc | 2 | ||||
| -rw-r--r-- | src/env.h | 2 | ||||
| -rw-r--r-- | src/node_file.cc | 4 | ||||
| -rw-r--r-- | src/node_http_parser_llhttp.cc | 2 | ||||
| -rw-r--r-- | src/node_http_parser_traditional.cc | 2 | ||||
| -rw-r--r-- | src/node_internals.h | 4 | ||||
| -rw-r--r-- | src/node_postmortem_metadata.cc | 2 |
7 files changed, 9 insertions, 9 deletions
diff --git a/src/env.cc b/src/env.cc index 023e69665d..ed6717d684 100644 --- a/src/env.cc +++ b/src/env.cc @@ -65,7 +65,7 @@ class TraceEventScope { }; int const Environment::kNodeContextTag = 0x6e6f64; -void* Environment::kNodeContextTagPtr = const_cast<void*>( +void* const Environment::kNodeContextTagPtr = const_cast<void*>( static_cast<const void*>(&Environment::kNodeContextTag)); IsolateData::IsolateData(Isolate* isolate, @@ -972,7 +972,7 @@ class Environment { uint64_t thread_id_ = 0; std::unordered_set<worker::Worker*> sub_worker_contexts_; - static void* kNodeContextTagPtr; + static void* const kNodeContextTagPtr; static int const kNodeContextTag; #if HAVE_INSPECTOR diff --git a/src/node_file.cc b/src/node_file.cc index 49d3167294..b66c0fe6d2 100644 --- a/src/node_file.cc +++ b/src/node_file.cc @@ -81,9 +81,9 @@ using v8::Value; #endif #ifdef __POSIX__ -const char* kPathSeparator = "/"; +constexpr char kPathSeparator = '/'; #else -const char* kPathSeparator = "\\/"; +const char* const kPathSeparator = "\\/"; #endif #define GET_OFFSET(a) ((a)->IsNumber() ? (a).As<Integer>()->Value() : -1) diff --git a/src/node_http_parser_llhttp.cc b/src/node_http_parser_llhttp.cc index 7b9999d13c..8728fa2b67 100644 --- a/src/node_http_parser_llhttp.cc +++ b/src/node_http_parser_llhttp.cc @@ -4,7 +4,7 @@ namespace node { -const char* llhttp_version = +const char* const llhttp_version = NODE_STRINGIFY(LLHTTP_VERSION_MAJOR) "." NODE_STRINGIFY(LLHTTP_VERSION_MINOR) diff --git a/src/node_http_parser_traditional.cc b/src/node_http_parser_traditional.cc index 2bff20c165..2ea452239a 100644 --- a/src/node_http_parser_traditional.cc +++ b/src/node_http_parser_traditional.cc @@ -6,7 +6,7 @@ namespace node { -const char* http_parser_version = +const char* const http_parser_version = NODE_STRINGIFY(HTTP_PARSER_VERSION_MAJOR) "." NODE_STRINGIFY(HTTP_PARSER_VERSION_MINOR) diff --git a/src/node_internals.h b/src/node_internals.h index 1d43d4b141..9c0b8ac3a7 100644 --- a/src/node_internals.h +++ b/src/node_internals.h @@ -697,8 +697,8 @@ static inline const char* errno_string(int errorno) { extern double prog_start_time; -extern const char* llhttp_version; -extern const char* http_parser_version; +extern const char* const llhttp_version; +extern const char* const http_parser_version; void Abort(const v8::FunctionCallbackInfo<v8::Value>& args); void Chdir(const v8::FunctionCallbackInfo<v8::Value>& args); diff --git a/src/node_postmortem_metadata.cc b/src/node_postmortem_metadata.cc index 93bf5a4dd7..527bfb623e 100644 --- a/src/node_postmortem_metadata.cc +++ b/src/node_postmortem_metadata.cc @@ -60,6 +60,6 @@ int GenDebugSymbols() { return 1; } -int debug_symbols_generated = GenDebugSymbols(); +const int debug_symbols_generated = GenDebugSymbols(); } // namespace node |