diff options
| author | Kyle Farnung <kfarnung@microsoft.com> | 2018-01-05 18:19:36 -0800 |
|---|---|---|
| committer | Kyle Farnung <kfarnung@microsoft.com> | 2018-01-16 17:09:14 -0800 |
| commit | cd60c7db5fe04c6a53b7dd8784ad0b52af30958d (patch) | |
| tree | d5499862ac37053a48137a6d4763e11f93932ce3 /vcbuild.bat | |
| parent | e08cf1d2309fb4368f11277e7021fa6d63790b9d (diff) | |
| download | android-node-v8-cd60c7db5fe04c6a53b7dd8784ad0b52af30958d.tar.gz android-node-v8-cd60c7db5fe04c6a53b7dd8784ad0b52af30958d.tar.bz2 android-node-v8-cd60c7db5fe04c6a53b7dd8784ad0b52af30958d.zip | |
build,win: update lint-cpp on Windows
* Added a `lint-cpp` argument
* Updated `findstr` calls to output to `nul`
* Updated `findstr` calls to only use `/r` when the input is a regex
PR-URL: https://github.com/nodejs/node/pull/18012
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Diffstat (limited to 'vcbuild.bat')
| -rw-r--r-- | vcbuild.bat | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/vcbuild.bat b/vcbuild.bat index 409df48b4c..74f7787113 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -90,6 +90,7 @@ if /i "%1"=="test-v8" set test_v8=1&set custom_v8_test=1&goto arg-ok if /i "%1"=="test-v8-intl" set test_v8_intl=1&set custom_v8_test=1&goto arg-ok if /i "%1"=="test-v8-benchmarks" set test_v8_benchmarks=1&set custom_v8_test=1&goto arg-ok if /i "%1"=="test-v8-all" set test_v8=1&set test_v8_intl=1&set test_v8_benchmarks=1&set custom_v8_test=1&goto arg-ok +if /i "%1"=="lint-cpp" set lint_cpp=1&goto arg-ok if /i "%1"=="lint-js" set lint_js=1&goto arg-ok if /i "%1"=="jslint" set lint_js=1&echo Please use lint-js instead of jslint&goto arg-ok if /i "%1"=="lint-js-ci" set lint_js_ci=1&goto arg-ok @@ -481,22 +482,23 @@ call :run-python tools/cpplint.py %cppfilelist% > nul goto exit :add-to-list -echo %1 | findstr /c:"src\node_root_certs.h" +@rem Subroutine used to filter items from the cpplint file list +echo %1 | findstr /c:"src\node_root_certs.h" > nul 2>&1 if %errorlevel% equ 0 goto exit -echo %1 | findstr /r /c:"src\\tracing\\trace_event.h" +echo %1 | findstr /c:"src\tracing\trace_event.h" > nul 2>&1 if %errorlevel% equ 0 goto exit -echo %1 | findstr /r /c:"src\\tracing\\trace_event_common.h" +echo %1 | findstr /c:"src\tracing\trace_event_common.h" > nul 2>&1 if %errorlevel% equ 0 goto exit -echo %1 | findstr /r /c:"test\\addons\\[0-9].*_.*\.h" +echo %1 | findstr /r /c:"test\\addons\\[0-9].*_.*\.h" > nul 2>&1 if %errorlevel% equ 0 goto exit -echo %1 | findstr /r /c:"test\\addons\\[0-9].*_.*\.cc" +echo %1 | findstr /r /c:"test\\addons\\[0-9].*_.*\.cc" > nul 2>&1 if %errorlevel% equ 0 goto exit -echo %1 | findstr /c:"test\\addons-napi\\common.h" +echo %1 | findstr /c:"test\addons-napi\common.h" > nul 2>&1 if %errorlevel% equ 0 goto exit set "localcppfilelist=%localcppfilelist% %1" |