diff options
| author | Josh Dague <daguej@email.uc.edu> | 2014-03-26 01:26:17 -0400 |
|---|---|---|
| committer | Timothy J Fontaine <tjfontaine@gmail.com> | 2014-03-27 11:54:13 -0700 |
| commit | a9d22247ad2b519a42a9eb63a0531ad337554723 (patch) | |
| tree | fe9e8d10edeabae93b0bf0dbe7ee319e7034d73a /vcbuild.bat | |
| parent | f68a116c3c061151ab120f10fdc9230192d6b157 (diff) | |
| download | android-node-v8-a9d22247ad2b519a42a9eb63a0531ad337554723.tar.gz android-node-v8-a9d22247ad2b519a42a9eb63a0531ad337554723.tar.bz2 android-node-v8-a9d22247ad2b519a42a9eb63a0531ad337554723.zip | |
build: windows signing should include timestamps
Previously the build artifacts did not include a signed timestamp, so
when the certificate expired the validation of the artifact would fail.
Now we sign against a timestamp server such that the artifact will
always be valid regardless of the disposition of the certificate.
Closes #7360 and #7059.
Diffstat (limited to 'vcbuild.bat')
| -rw-r--r-- | vcbuild.bat | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/vcbuild.bat b/vcbuild.bat index 849374b593..0c9b0b285a 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -136,7 +136,8 @@ if errorlevel 1 goto exit @rem Skip signing if the `nosign` option was specified. if defined nosign goto licensertf -signtool sign /a Release\node.exe +signtool sign /a /d "Node.js" /t http://timestamp.globalsign.com/scripts/timestamp.dll Release\node.exe +if errorlevel 1 echo Failed to sign exe&goto exit :licensertf @rem Skip license.rtf generation if not requested. @@ -159,7 +160,8 @@ msbuild "%~dp0tools\msvs\msi\nodemsi.sln" /m /t:Clean,Build /p:Configuration=%co if errorlevel 1 goto exit if defined nosign goto run -signtool sign /a Release\node-v%NODE_VERSION%-%msiplatform%.msi +signtool sign /a /d "Node.js" /t http://timestamp.globalsign.com/scripts/timestamp.dll Release\node-v%NODE_VERSION%-%msiplatform%.msi +if errorlevel 1 echo Failed to sign msi&goto exit :run @rem Run tests if requested. |