diff options
| author | Richard Lau <riclau@uk.ibm.com> | 2019-10-08 12:57:09 -0400 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-10-10 11:58:10 -0700 |
| commit | 4885e50f7ef7f77a87fbb9f56fb088afebfa8b4a (patch) | |
| tree | c55828d7add7bd4c8c05554d909709bb0099788a /vcbuild.bat | |
| parent | 458a38c904c78b072f4b49c45dda7c63987bb60b (diff) | |
| download | android-node-v8-4885e50f7ef7f77a87fbb9f56fb088afebfa8b4a.tar.gz android-node-v8-4885e50f7ef7f77a87fbb9f56fb088afebfa8b4a.tar.bz2 android-node-v8-4885e50f7ef7f77a87fbb9f56fb088afebfa8b4a.zip | |
build: make full-icu the default for releases
Release builds specifically set the `--with-intl=` configure option
instead of relying on the default. Explicitly set to `full-icu`.
Refs: https://github.com/nodejs/node/pull/29522
PR-URL: https://github.com/nodejs/node/pull/29887
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'vcbuild.bat')
| -rw-r--r-- | vcbuild.bat | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/vcbuild.bat b/vcbuild.bat index 72f20a4835..7613bd8b5a 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -120,7 +120,7 @@ if /i "%1"=="lint-md-build" set lint_md_build=1&goto arg-ok if /i "%1"=="lint" set lint_cpp=1&set lint_js=1&set lint_md=1&goto arg-ok if /i "%1"=="lint-ci" set lint_cpp=1&set lint_js_ci=1&goto arg-ok if /i "%1"=="package" set package=1&goto arg-ok -if /i "%1"=="msi" set msi=1&set licensertf=1&set download_arg="--download=all"&set i18n_arg=small-icu&goto arg-ok +if /i "%1"=="msi" set msi=1&set licensertf=1&set download_arg="--download=all"&set i18n_arg=full-icu&goto arg-ok if /i "%1"=="build-release" set build_release=1&set sign=1&goto arg-ok if /i "%1"=="upload" set upload=1&goto arg-ok if /i "%1"=="small-icu" set i18n_arg=%1&goto arg-ok @@ -158,7 +158,7 @@ if defined build_release ( set msi=1 set licensertf=1 set download_arg="--download=all" - set i18n_arg=small-icu + set i18n_arg=full-icu set projgen=1 set cctest=1 set ltcg=1 |